Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimplifiedType cleanups #105743

Merged
merged 2 commits into from
Dec 16, 2022
Merged

SimplifiedType cleanups #105743

merged 2 commits into from
Dec 16, 2022

Conversation

nnethercote
Copy link
Contributor

r? @lcnr

@nnethercote
Remove SimplifiedTypeGen::map_def.
2a5aabd 
It's unused.
@nnethercote
Merge SimplifiedTypeGen<D> into SimplifiedType.
5258b65 
`SimplifiedTypeGen<DefId>` is the only instantiation used, so we don't
need the generic parameter.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 15, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@nnethercote
Copy link
Contributor Author

Best reviewed one commit at a time.

@nnethercote
Copy link
Contributor Author

@bors rollup

@lcnr
Copy link
Contributor

lcnr commented Dec 15, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 15, 2022

📌 Commit 5258b65 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 15, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2022
@bors
Auto merge of rust-lang#105760 - matthiaskrgr:rollup-r8beo9w, r=matth…
7a6af27 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105481 (Start improving monomorphization items stats)
 - rust-lang#105674 (Point at method chains on `E0271` errors)
 - rust-lang#105679 (Suggest constraining type parameter with `Clone`)
 - rust-lang#105694 (Don't create dummy if val has escaping bounds var)
 - rust-lang#105727 (Tweak output for bare `dyn Trait` in arguments)
 - rust-lang#105739 (Migrate Jump to def links background to CSS variable)
 - rust-lang#105743 (`SimplifiedType` cleanups)
 - rust-lang#105758 (Move `TypeckResults` to separate module)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0f90ea9 into rust-lang:master Dec 16, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 16, 2022
@nnethercote nnethercote deleted the SimplifiedType-cleanups branch December 16, 2022 03:16
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#105743 - nnethercote:SimplifiedType-cleanup…
cfe1e04 
…s, r=lcnr

`SimplifiedType` cleanups

r? `@lcnr`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nnethercote @rustbot @lcnr @bors