More deriving on packed structs #104429

nnethercote · 2022-11-15T04:19:42Z

See here for the t-lang nomination summary, and here for the approval.

rustbot · 2022-11-15T04:19:49Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

nnethercote · 2022-11-15T04:21:26Z

Note that the first three commits are from #104391, and have already been approved.

@RalfJung: even though you don't know the deriving code, there is enough stuff in this PR that you do know about (e.g. unsafe_derive_on_repr_packed) that I would like your review. If you want another co-reviewer as well I think that's fine.

nnethercote · 2022-11-15T04:34:42Z

@bors try

bors · 2022-11-15T04:34:52Z

⌛ Trying commit 1e84976f23459b2afa61c169c440b98637d8f747 with merge a31ace633f6135f7232aa68f2493896256980c6a...

bors · 2022-11-15T07:15:28Z

☀️ Try build successful - checks-actions
Build commit: a31ace633f6135f7232aa68f2493896256980c6a (a31ace633f6135f7232aa68f2493896256980c6a)

src/test/ui/deriving/deriving-all-codegen.stdout

RalfJung · 2022-11-15T07:54:04Z

src/test/ui/derives/deriving-with-repr-packed.rs

 // This one is fine because it's not packed.
 #[derive(Debug, Default)]
 struct Y(usize);

+// This one has an error because `Y` doesn't impl `Copy`.
+// Note: there is room for improvement in the error message.


Yes there is indeed.^^ I noticed some other derive get really nice error messages but I have no idea how they do that. I suspect it is related to these AssertParamIs things?

src/test/ui/deriving/deriving-all-codegen.rs

RalfJung · 2022-11-15T07:59:22Z

src/test/ui/derives/deriving-with-repr-packed-2.rs

+    // This one is an error because `Box<u32>` doesn't impl `Copy`.
+    let x: Foo<NonCopy> = Foo(NonCopy, NonCopy, NonCopy);
+    _ = x.clone();
+    //~^ ERROR the method `clone` exists for struct `Foo<NonCopy>`, but its trait bounds were not satisfied


This is where I wonder how we can best document this. Users might be surprised here that Clone doesn't work since they did derive(Clone) and all fields are Clone...

RalfJung · 2022-11-15T08:05:14Z

I looked at the testcases only; there are some more that should be added:

non-generic with Copy+Clone (should get simple clone)
non-generic with only Clone, no Copy (should work -- just to make sure this kicks in even when there are no generics)
generic using an associated type (needs the extra bound on the where)

Looks like we don't even have a test for generic+associated without packed; that would be good to have, too.

The changes in check_packed_ref are fine, too.

I'll hand over review of the actual implementation to someone else, don't have the time to dig into the derive code currently, sorry. r? compiler

nnethercote · 2022-11-16T02:00:06Z

@bors try

bors · 2022-11-16T02:00:14Z

⌛ Trying commit f23921e2784a92f203f389cebc75bc7656d86124 with merge b2686d78d0034bb3435b348d5a63910b074a1990...

bors · 2022-11-16T04:40:36Z

☀️ Try build successful - checks-actions
Build commit: b2686d78d0034bb3435b348d5a63910b074a1990 (b2686d78d0034bb3435b348d5a63910b074a1990)

nnethercote · 2022-11-16T05:33:24Z

@craterbot check

craterbot · 2022-11-16T05:33:30Z

👌 Experiment pr-104429 created and queued.
🤖 Automatically detected try build b2686d78d0034bb3435b348d5a63910b074a1990
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-11-16T07:53:05Z

🚧 Experiment pr-104429 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2022-11-17T05:24:25Z

🎉 Experiment pr-104429 is completed!
📊 70 regressed and 15 fixed (248247 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rust-timer · 2023-01-30T11:56:51Z

Finished benchmarking commit (3f25e56): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-1.3%, -0.3%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.5%	[3.2%, 3.8%]	2
Regressions ❌ (secondary)	3.7%	[2.6%, 5.4%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.5%, -1.3%]	2
All ❌✅ (primary)	3.5%	[3.2%, 3.8%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Manishearth · 2023-02-02T16:19:36Z

@RalfJung FWIW I was under the impression we'd found all the cases where zerovec relies on this, but turns out we were producing this in a custom derive as well (unicode-org/icu4x#3069).

RalfJung · 2023-02-02T16:24:14Z

Ouch, strange that crater missed that.

The issue unicode-org/icu4x#3060 mentions str. We could probably treat that like [u8] and make it a future-compat warning instead of a hard error. Would that help?

Manishearth · 2023-02-02T16:27:26Z

That would be great, yeah. It's already fixed on our end so it's not a huge deal, but I'm surprised this didn't crop up in future-incompat warnings at all.

RalfJung · 2023-02-02T16:28:15Z

Ah no there's also other types like MultiFieldsULE. I don't see a good way that we can detect those... other than the crude hack of just checking the name of the type (and of the crate it is defined in).

Do I understand correctly that right now the [u8] hack we added is useless because icu4x fails to build anyway?

I'm surprised this didn't crop up in future-incompat warnings at all.

We didn't find a way to have future-incompat warnings for this deriving change.

RalfJung · 2023-02-02T16:31:32Z

Specifically I think this is the list of types we'd have to treat like [u8]:

str
VarZeroSlice<str>
MultiFieldsULE

I think this is pre-name-resolution so we can only go by their name, we can't query their alignment or anything like that. Is there precedent for carrying hacks for specific type / crate names to ease a transition?

Manishearth · 2023-02-02T16:45:31Z

Do I understand correctly that right now the [u8] hack we added is useless because icu4x fails to build anyway?

Yeah we use other types at the end; we have a ZeroSlice and VarZeroSlice and MultiFieldsULE in use in ICU4X right now I think.

I think it's still potentially useful for others though!

Is there precedent for carrying hacks for specific type / crate names to ease a transition?

I don't think so?

But again I've already fixed it in zerovec (pending PR merge) and it's compatible with the zerovec version used in ICU4X 1.0, so users canjust update.

RalfJung · 2023-02-02T16:57:14Z

I think it's still potentially useful for others though!

Ah, because it's a macro that could be used elsewhere?

Just adding str to the exception should be easy. @nnethercote do you have time to look into this?

Manishearth · 2023-02-02T17:49:23Z

Ah, because it's a macro that could be used elsewhere?

Yep! The most common things to use it with are string and slice types.

nnethercote · 2023-02-02T19:39:52Z

Yeah, I can add str.

nnethercote · 2023-02-06T02:00:59Z

Yeah, I can add str.

#107713

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * Sadly, the patch to reduce the cargo verbosity no longer applies, so I've asked upstream about the proper way to get the old result. (so the build log becomes Quite Bloated for now). Upstream changes: Version 1.69.0 (2023-04-20) ========================== Language -------- - [Deriving built-in traits on packed structs works with `Copy` fields.] (rust-lang/rust#104429) - [Stabilize the `cmpxchg16b` target feature on x86 and x86_64.] (rust-lang/rust#106774) - [Improve analysis of trait bounds for associated types.] (rust-lang/rust#103695) - [Allow associated types to be used as union fields.] (rust-lang/rust#106938) - [Allow `Self: Autotrait` bounds on dyn-safe trait methods.] (rust-lang/rust#107082) - [Treat `str` as containing `[u8]` for auto trait purposes.] (rust-lang/rust#107941) Compiler -------- - [Upgrade `*-pc-windows-gnu` on CI to mingw-w64 v10 and GCC 12.2.] (rust-lang/rust#100178) - [Rework min_choice algorithm of member constraints.] (rust-lang/rust#105300) - [Support `true` and `false` as boolean flags in compiler arguments.] (rust-lang/rust#107043) - [Default `repr(C)` enums to `c_int` size.] (rust-lang/rust#107592) Libraries --------- - [Implement the unstable `DispatchFromDyn` for cell types, allowing downstream experimentation with custom method receivers.] (rust-lang/rust#97373) - [Document that `fmt::Arguments::as_str()` may return `Some(_)` in more cases after optimization, subject to change.] (rust-lang/rust#106823) - [Implement `AsFd` and `AsRawFd` for `Rc`.] (rust-lang/rust#107317) Stabilized APIs --------------- - [`CStr::from_bytes_until_nul`] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html#method.from_bytes_until_nul) - [`core::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesUntilNulError.html) These APIs are now stable in const contexts: - [`SocketAddr::new`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.new) - [`SocketAddr::ip`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.ip) - [`SocketAddr::port`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.port) - [`SocketAddr::is_ipv4`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv4) - [`SocketAddr::is_ipv6`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv6) - [`SocketAddrV4::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.new) - [`SocketAddrV4::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.ip) - [`SocketAddrV4::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.port) - [`SocketAddrV6::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.new) - [`SocketAddrV6::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.ip) - [`SocketAddrV6::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.port) - [`SocketAddrV6::flowinfo`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.flowinfo) - [`SocketAddrV6::scope_id`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.scope_id) Cargo ----- - [Cargo now suggests `cargo fix` or `cargo clippy --fix` when compilation warnings are auto-fixable.] (rust-lang/cargo#11558) - [Cargo now suggests `cargo add` if you try to install a library crate.] (rust-lang/cargo#11410) - [Cargo now sets the `CARGO_BIN_NAME` environment variable also for binary examples.] (rust-lang/cargo#11705) Rustdoc ----- - [Vertically compact trait bound formatting.] (rust-lang/rust#102842) - [Only include stable lints in `rustdoc::all` group.] (rust-lang/rust#106316) - [Compute maximum Levenshtein distance based on the query.] (rust-lang/rust#107141) - [Remove inconsistently-present sidebar tooltips.] (rust-lang/rust#107490) - [Search by macro when query ends with `!`.] (rust-lang/rust#108143) Compatibility Notes ------------------- - [The `rust-analysis` component from `rustup` now only contains a warning placeholder.] (rust-lang/rust#101841) This was primarily intended for RLS, and the corresponding `-Zsave-analysis` flag has been removed from the compiler as well. - [Unaligned references to packed fields are now a hard error.] (rust-lang/rust#102513) This has been a warning since 1.53, and denied by default with a future-compatibility warning since 1.62. - [Update the minimum external LLVM to 14.] (rust-lang/rust#107573) - [Cargo now emits errors on invalid characters in a registry token.] (rust-lang/cargo#11600) - [When `default-features` is set to false of a workspace dependency, and an inherited dependency of a member has `default-features = true`, Cargo will enable default features of that dependency.] (rust-lang/cargo#11409) - [Cargo denies `CARGO_HOME` in the `[env]` configuration table. Cargo itself doesn't pick up this value, but recursive calls to cargo would, which was not intended.] (rust-lang/cargo#11644) - [Debuginfo for build dependencies is now off if not explicitly set. This is expected to improve the overall build time.] (rust-lang/cargo#11252) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Move `format_args!()` into AST (and expand it during AST lowering)] (rust-lang/rust#106745)

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. Upstream changes: Version 1.69.0 (2023-04-20) ========================== Language -------- - [Deriving built-in traits on packed structs works with `Copy` fields.] (rust-lang/rust#104429) - [Stabilize the `cmpxchg16b` target feature on x86 and x86_64.] (rust-lang/rust#106774) - [Improve analysis of trait bounds for associated types.] (rust-lang/rust#103695) - [Allow associated types to be used as union fields.] (rust-lang/rust#106938) - [Allow `Self: Autotrait` bounds on dyn-safe trait methods.] (rust-lang/rust#107082) - [Treat `str` as containing `[u8]` for auto trait purposes.] (rust-lang/rust#107941) Compiler -------- - [Upgrade `*-pc-windows-gnu` on CI to mingw-w64 v10 and GCC 12.2.] (rust-lang/rust#100178) - [Rework min_choice algorithm of member constraints.] (rust-lang/rust#105300) - [Support `true` and `false` as boolean flags in compiler arguments.] (rust-lang/rust#107043) - [Default `repr(C)` enums to `c_int` size.] (rust-lang/rust#107592) Libraries --------- - [Implement the unstable `DispatchFromDyn` for cell types, allowing downstream experimentation with custom method receivers.] (rust-lang/rust#97373) - [Document that `fmt::Arguments::as_str()` may return `Some(_)` in more cases after optimization, subject to change.] (rust-lang/rust#106823) - [Implement `AsFd` and `AsRawFd` for `Rc`.] (rust-lang/rust#107317) Stabilized APIs --------------- - [`CStr::from_bytes_until_nul`] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html#method.from_bytes_until_nul) - [`core::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesUntilNulError.html) These APIs are now stable in const contexts: - [`SocketAddr::new`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.new) - [`SocketAddr::ip`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.ip) - [`SocketAddr::port`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.port) - [`SocketAddr::is_ipv4`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv4) - [`SocketAddr::is_ipv6`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv6) - [`SocketAddrV4::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.new) - [`SocketAddrV4::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.ip) - [`SocketAddrV4::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.port) - [`SocketAddrV6::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.new) - [`SocketAddrV6::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.ip) - [`SocketAddrV6::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.port) - [`SocketAddrV6::flowinfo`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.flowinfo) - [`SocketAddrV6::scope_id`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.scope_id) Cargo ----- - [Cargo now suggests `cargo fix` or `cargo clippy --fix` when compilation warnings are auto-fixable.] (rust-lang/cargo#11558) - [Cargo now suggests `cargo add` if you try to install a library crate.] (rust-lang/cargo#11410) - [Cargo now sets the `CARGO_BIN_NAME` environment variable also for binary examples.] (rust-lang/cargo#11705) Rustdoc ----- - [Vertically compact trait bound formatting.] (rust-lang/rust#102842) - [Only include stable lints in `rustdoc::all` group.] (rust-lang/rust#106316) - [Compute maximum Levenshtein distance based on the query.] (rust-lang/rust#107141) - [Remove inconsistently-present sidebar tooltips.] (rust-lang/rust#107490) - [Search by macro when query ends with `!`.] (rust-lang/rust#108143) Compatibility Notes ------------------- - [The `rust-analysis` component from `rustup` now only contains a warning placeholder.] (rust-lang/rust#101841) This was primarily intended for RLS, and the corresponding `-Zsave-analysis` flag has been removed from the compiler as well. - [Unaligned references to packed fields are now a hard error.] (rust-lang/rust#102513) This has been a warning since 1.53, and denied by default with a future-compatibility warning since 1.62. - [Update the minimum external LLVM to 14.] (rust-lang/rust#107573) - [Cargo now emits errors on invalid characters in a registry token.] (rust-lang/cargo#11600) - [When `default-features` is set to false of a workspace dependency, and an inherited dependency of a member has `default-features = true`, Cargo will enable default features of that dependency.] (rust-lang/cargo#11409) - [Cargo denies `CARGO_HOME` in the `[env]` configuration table. Cargo itself doesn't pick up this value, but recursive calls to cargo would, which was not intended.] (rust-lang/cargo#11644) - [Debuginfo for build dependencies is now off if not explicitly set. This is expected to improve the overall build time.] (rust-lang/cargo#11252) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Move `format_args!()` into AST (and expand it during AST lowering)] (rust-lang/rust#106745)

add another exception This failed with the same error in both runs in rust-lang/rust#104429. Doesn't crater run both builds in the same clean environment? We seem to have a bunch of cases of "baseline always works but try build always fails". It almost seems like the 'try' run can see artifacts created by the baseline, and that breaks quite a few poorly written build scripts out there.

…_with_derive, r=<try> built-in derive: remove BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE hack and lint Fixes rust-lang#107457 by turning the lint into a hard error. The lint has been shown in future breakage reports since Rust 1.69 (released in April 2023). Let's see (via crater) if enough time has passed since rust-lang#104429, and unicode-org/icu4x#2834 has propagated far enough to let us make this a hard error. TODO: actually remove the lint. Cc `@nnethercote` `@Manishearth`

…ct_with_derive, r=nnethercote built-in derive: remove BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE hack and lint Fixes rust-lang#107457 by turning the lint into a hard error. The lint has been shown in future breakage reports since Rust 1.69 (released in April 2023). Let's see (via crater) if enough time has passed since rust-lang#104429, and unicode-org/icu4x#2834 has propagated far enough to let us make this a hard error. Cc `@nnethercote` `@Manishearth`

…ct_with_derive, r=nnethercote built-in derive: remove BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE hack and lint Fixes rust-lang#107457 by turning the lint into a hard error. The lint has been shown in future breakage reports since Rust 1.69 (released in April 2023). Let's see (via crater) if enough time has passed since rust-lang#104429, and unicode-org/icu4x#2834 has propagated far enough to let us make this a hard error. Cc ``@nnethercote`` ``@Manishearth``

Rollup merge of rust-lang#127907 - RalfJung:byte_slice_in_packed_struct_with_derive, r=nnethercote built-in derive: remove BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE hack and lint Fixes rust-lang#107457 by turning the lint into a hard error. The lint has been shown in future breakage reports since Rust 1.69 (released in April 2023). Let's see (via crater) if enough time has passed since rust-lang#104429, and unicode-org/icu4x#2834 has propagated far enough to let us make this a hard error. Cc ``@nnethercote`` ``@Manishearth``

rustbot assigned RalfJung Nov 15, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 15, 2022

nnethercote mentioned this pull request Nov 15, 2022

Tracking Issue for future-incompatibility warning unaligned_references #82523

Closed

nnethercote force-pushed the more-deriving-on-packed-structs branch from f26d1f5 to 1e84976 Compare November 15, 2022 04:32

RalfJung reviewed Nov 15, 2022

View reviewed changes

src/test/ui/deriving/deriving-all-codegen.stdout Outdated Show resolved Hide resolved

RalfJung reviewed Nov 15, 2022

View reviewed changes

src/test/ui/deriving/deriving-all-codegen.rs Outdated Show resolved Hide resolved

RalfJung reviewed Nov 15, 2022

View reviewed changes

rustbot assigned compiler-errors and unassigned RalfJung Nov 15, 2022

RalfJung mentioned this pull request Nov 15, 2022

backport switch to winapi 0.3 onto mio 0.6 tokio-rs/mio#1629

Closed

nnethercote force-pushed the more-deriving-on-packed-structs branch from 1e84976 to f23921e Compare November 16, 2022 01:06

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2022

bors mentioned this pull request Jan 30, 2023

99144 enable doctests #106574

Closed

nnethercote deleted the more-deriving-on-packed-structs branch January 30, 2023 21:11

nnethercote mentioned this pull request Jan 30, 2023

Fix syntax in -Zunpretty-expanded output for derived PartialEq. #107488

Merged

RalfJung mentioned this pull request Jan 31, 2023

make unaligned_reference a hard error #102513

Merged

This was referenced Feb 2, 2023

Compile error with recent nightly toolchain unicode-org/icu4x#3060

Closed

Avoid using derive on autogenerated packed types, bump zerovec-derive to 0.9.3 unicode-org/icu4x#3069

Merged

nnethercote mentioned this pull request Feb 17, 2023

ICE in unaligned references MIR check #108122

Closed

Mark-Simulacrum mentioned this pull request Mar 30, 2023

regression: cannot move out of shared reference #109744

Closed

LegionMammal978 mentioned this pull request Apr 21, 2023

Making unaligned_references a hard error broke derives on packed structs without warning #110645

Closed

nnethercote mentioned this pull request Oct 23, 2023

Erroneous warning about packed struct not implementing Copy #71740

Closed

RalfJung mentioned this pull request Jul 18, 2024

built-in derive: remove BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE hack and lint #127907

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More deriving on packed structs #104429

More deriving on packed structs #104429

nnethercote commented Nov 15, 2022 •

edited

Loading

rustbot commented Nov 15, 2022

nnethercote commented Nov 15, 2022

nnethercote commented Nov 15, 2022

bors commented Nov 15, 2022

bors commented Nov 15, 2022

RalfJung Nov 15, 2022

RalfJung Nov 15, 2022

RalfJung commented Nov 15, 2022

nnethercote commented Nov 16, 2022

bors commented Nov 16, 2022

bors commented Nov 16, 2022

nnethercote commented Nov 16, 2022

craterbot commented Nov 16, 2022

craterbot commented Nov 16, 2022

craterbot commented Nov 17, 2022

rust-timer commented Jan 30, 2023

Manishearth commented Feb 2, 2023

RalfJung commented Feb 2, 2023 •

edited

Loading

Manishearth commented Feb 2, 2023

RalfJung commented Feb 2, 2023 •

edited

Loading

RalfJung commented Feb 2, 2023 •

edited

Loading

Manishearth commented Feb 2, 2023

RalfJung commented Feb 2, 2023

Manishearth commented Feb 2, 2023

nnethercote commented Feb 2, 2023

nnethercote commented Feb 6, 2023

More deriving on packed structs #104429

More deriving on packed structs #104429

Conversation

nnethercote commented Nov 15, 2022 • edited Loading

rustbot commented Nov 15, 2022

nnethercote commented Nov 15, 2022

nnethercote commented Nov 15, 2022

bors commented Nov 15, 2022

bors commented Nov 15, 2022

RalfJung Nov 15, 2022

Choose a reason for hiding this comment

RalfJung Nov 15, 2022

Choose a reason for hiding this comment

RalfJung commented Nov 15, 2022

nnethercote commented Nov 16, 2022

bors commented Nov 16, 2022

bors commented Nov 16, 2022

nnethercote commented Nov 16, 2022

craterbot commented Nov 16, 2022

craterbot commented Nov 16, 2022

craterbot commented Nov 17, 2022

rust-timer commented Jan 30, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Manishearth commented Feb 2, 2023

RalfJung commented Feb 2, 2023 • edited Loading

Manishearth commented Feb 2, 2023

RalfJung commented Feb 2, 2023 • edited Loading

RalfJung commented Feb 2, 2023 • edited Loading

Manishearth commented Feb 2, 2023

RalfJung commented Feb 2, 2023

Manishearth commented Feb 2, 2023

nnethercote commented Feb 2, 2023

nnethercote commented Feb 6, 2023

nnethercote commented Nov 15, 2022 •

edited

Loading

RalfJung commented Feb 2, 2023 •

edited

Loading

RalfJung commented Feb 2, 2023 •

edited

Loading

RalfJung commented Feb 2, 2023 •

edited

Loading