Enable internal feature when testing Clippy #104007

flip1995 · 2022-11-05T14:23:42Z

Clippy has internal lints, that only get build and tested, when the internal feature is enabled. Those tests are just regular UI tests, but split out from the normal UI tests, because they usually don't have to be touched when changing something in Clippy. However, changes to Rust internals often require updates of the internal lints, just as for the Rest of the Clippy codebase. Currently I fix this fallout during the sync. But this can lead to sync blockers in rare occasions.

Blocked on #104006, because it will fail Clippy build/tests until that is merged.

This will prevent fallouts like the one in #103603

r? @jyn514

jyn514 · 2022-11-05T14:38:03Z

👍 seems good - I remember this having interactions with #96798, but I don't know when I'll get back to that PR, so this is fine in the meantime.

…p1995 Update Clippy r? `@Manishearth` Sorry for taking so long. There were so many blockers and so little time. This situation should be mitigated with rust-lang#104007 in the future.

jyn514 · 2022-11-24T23:49:46Z

@bors r+ rollup=iffy (clippy isn't tested in PR CI)

bors · 2022-11-24T23:49:48Z

📌 Commit 075f4c49a30fede0b7ed91f56a4928ef717ba224 has been approved by jyn514

It is now in the queue for this repository.

bors · 2022-11-25T02:54:49Z

⌛ Testing commit 075f4c49a30fede0b7ed91f56a4928ef717ba224 with merge 4d35d8785bbfdb2ac53632555885fde767afaa9d...

bors · 2022-11-25T03:17:20Z

💔 Test failed - checks-actions

Clippy has internal lints, that only get build and tested, when the `internal` feature is enabled. Those tests are just regular UI tests, but split out from the normal UI tests, because they usually don't have to be touched when changing something in Clippy. However, changes to Rust internals often require updates of the internal lints, just as for the Rest of the Clippy codebase. Currently I fix this fallout during the sync. But this can lead to sync blockers in rare occasions.

rustbot · 2022-11-25T11:07:33Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

flip1995 · 2022-11-25T11:08:38Z

The order of the lint messages in

ui-internal/unnecessary_def_path_hardcoded_path.rs

seems to be different between the Clippy and the Rust repo. This is weird. 🤔

@rustbot ready

rust-log-analyzer · 2022-11-25T12:41:30Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between 41e0363055ade59584cff667c79f64937e6ef3f9 and 3e812cc745400bd9edd227d181ad866aca6b1881
Tool subtrees were updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s


running 14 tests
test [ui] ui-internal/invalid_paths.rs ... ok
test [ui] ui-internal/if_chain_style.rs ... ok
test [ui] ui-internal/unnecessary_def_path_hardcoded_path.rs ... ok
test [ui] ui-internal/default_deprecation_reason.rs ... ok
test [ui] ui-internal/default_lint.rs ... ok
test [ui] ui-internal/lint_without_lint_pass.rs ... ok
test [ui] ui-internal/check_clippy_version_attribute.rs ... ok
test [ui] ui-internal/interning_defined_symbol.rs ... ok
test [ui] ui-internal/unnecessary_symbol_str.rs ... ok
test [ui] ui-internal/custom_ice_message.rs ... FAILED
test [ui] ui-internal/invalid_msrv_attr_impl.rs ... ok
test [ui] ui-internal/collapsible_span_lint_calls.rs ... ok
test [ui] ui-internal/outer_expn_data.rs ... ok
test [ui] ui-internal/unnecessary_def_path.rs ... ok
failures:

failures:
    [ui] ui-internal/custom_ice_message.rs
---

---- compile_test stdout ----
diff of stderr:

 thread '<unnamed>' panicked at 'Would you like some help with that?', clippy_lints/src/utils/internal_lints/produce_ice.rs:28:9
 
 error: internal compiler error: unexpected panic
 
 note: the compiler unexpectedly panicked. this is a bug.
 note: the compiler unexpectedly panicked. this is a bug.
 
 note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new
 
 note: Clippy version: foo
 
 query stack during panic:
 end of query stack
+thread '<unnamed>' panicked at 'Found a `push` without a `pop`.', compiler/rustc_lint/src/levels.rs:504:9
+stack backtrace:
+   0:     0x7fbe2c719936 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hf5c53e27eabb6c92
+   1:     0x7fbe2c787648 - core::fmt::write::h9adcac22ca1ada35
+   2:     0x7fbe2c70a9c1 - std::io::Write::write_fmt::hfc1b8644e676f68a
+   3:     0x7fbe2c719705 - std::sys_common::backtrace::print::h324c23e4df4fd21b
+   4:     0x7fbe2c71cba7 - std::panicking::default_hook::{{closure}}::h0d9f2773bf75edd6
+   5:     0x7fbe2c71c906 - std::panicking::default_hook::h0296363bafb07503
+   6:     0x56119fabd5df - clippy_driver[8a5d313b41b41c68]::ICE_HOOK::{closure#0}::{closure#0}
+   7:     0x7fbe2c71d4d3 - std::panicking::rust_panic_with_hook::h5b6dcf711341e085
+   8:     0x7fbe2c71d1c2 - std::panicking::begin_panic_handler::{{closure}}::hc0bcdaae2dbdd5e4
+   9:     0x7fbe2c719edc - std::sys_common::backtrace::__rust_end_short_backtrace::hc4161379984d54e2
+  10:     0x7fbe2c71ceb2 - rust_begin_unwind
+  11:     0x7fbe2c6cf133 - core::panicking::panic_fmt::h03752014e655c065
+  12:     0x7fbe2fd933a9 - <rustc_lint[d9358ae84c43d93b]::levels::BuilderPush as core[68faba315474d546]::ops::drop::Drop>::drop
+  13:     0x7fbe2d34692d - <rustc_lint[d9358ae84c43d93b]::early::EarlyContextAndPass<rustc_lint[d9358ae84c43d93b]::early::EarlyLintPassObjects> as rustc_ast[a41204963f2f886f]::visit::Visitor>::visit_item
+  14:     0x7fbe2d2e900c - rustc_ast[a41204963f2f886f]::visit::walk_crate::<rustc_lint[d9358ae84c43d93b]::early::EarlyContextAndPass<rustc_lint[d9358ae84c43d93b]::early::EarlyLintPassObjects>>
+  15:     0x7fbe2d3449ab - rustc_lint[d9358ae84c43d93b]::early::early_lint_node::<rustc_lint[d9358ae84c43d93b]::early::EarlyLintPassObjects, &rustc_ast[a41204963f2f886f]::ast::Crate>
+  16:     0x7fbe2d341339 - rustc_lint[d9358ae84c43d93b]::early::check_ast_node::<rustc_lint[d9358ae84c43d93b]::BuiltinCombinedEarlyLintPass, &rustc_ast[a41204963f2f886f]::ast::Crate>
+  17:     0x7fbe2d263cda - <rustc_session[255004e973edb88b]::session::Session>::time::<(), rustc_interface[521b6230467a61d]::passes::configure_and_expand::{closure#8}>
+  18:     0x7fbe2d2986c6 - rustc_interface[521b6230467a61d]::passes::configure_and_expand
+  19:     0x7fbe2d318b5d - <rustc_interface[521b6230467a61d]::queries::Queries>::expansion
+  20:     0x7fbe2d1516d5 - <rustc_interface[521b6230467a61d]::interface::Compiler>::enter::<rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}::{closure#2}, core[68faba315474d546]::result::Result<core[68faba315474d546]::option::Option<rustc_interface[521b6230467a61d]::queries::Linker>, rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>
+  21:     0x7fbe2d0cb651 - rustc_span[e4d44162dc051c57]::with_source_map::<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_interface[521b6230467a61d]::interface::run_compiler<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}>::{closure#0}::{closure#0}>
+  22:     0x7fbe2d152624 - <scoped_tls[a9f52a12973999a]::ScopedKey<rustc_span[e4d44162dc051c57]::SessionGlobals>>::set::<rustc_interface[521b6230467a61d]::interface::run_compiler<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}>::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>
+  23:     0x7fbe2d0fab40 - std[97d4460a24a895d5]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[521b6230467a61d]::util::run_in_thread_pool_with_globals<rustc_interface[521b6230467a61d]::interface::run_compiler<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}>::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>
+  24:     0x7fbe2d0e0173 - <<std[97d4460a24a895d5]::thread::Builder>::spawn_unchecked_<rustc_interface[521b6230467a61d]::util::run_in_thread_pool_with_globals<rustc_interface[521b6230467a61d]::interface::run_compiler<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}>::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>::{closure#1} as core[68faba315474d546]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
+  25:     0x7fbe2c72a1ee - std::sys::unix::thread::Thread::new::thread_start::h583a6f15dd367f1e
+  26:     0x7fbe2c3b7b43 - <unknown>
+  27:     0x7fbe2c449a00 - <unknown>
+  28:                0x0 - <unknown>
+error: internal compiler error: unexpected panic
+
+note: the compiler unexpectedly panicked. this is a bug.
+
---
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args custom_ice_message.rs`

error: 1 errors occurred comparing output.
status: signal: 6 (SIGABRT) (core dumped)
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "tests/ui-internal/custom_ice_message.rs" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui-internal" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui-internal/custom_ice_message.stage-id" "-A" "unused" "--emit=metadata" "-Dwarnings" "-Zui-testing" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-L" "dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsyn-7b5cc279bd04eca8.rlib" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-e0524b7e2611e851.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libitertools-b6f83e8bf7b1d2e3.rlib" "--extern" "rustc_semver=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/librustc_semver-963bbd3f89834643.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libparking_lot-f03750e49676bd17.rlib" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-d4b0c12069551999.rlib" "--extern" "derive_new=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libderive_new-a2f771a227dafeba.so" "--extern" "clippy_utils=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_utils-a009da3a546d2d45.rlib" "--extern" "if_chain=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libif_chain-03f75cdc6d4d3afc.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures-7a940bbcc1286cdc.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-edad3f22f7291185.rlib" "--extern" "serde_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps/libserde_derive-f7c308c5f8e7b09c.so" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-619ac20e364f2b2c.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libquote-e39b631048351f36.rlib" "--edition=2021" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/test/ui-internal/custom_ice_message.stage-id.aux"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
thread 'rustc' panicked at 'Would you like some help with that?', src/tools/clippy/clippy_lints/src/utils/internal_lints/produce_ice.rs:28:9

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.
note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.67 (3e812cc7 2022-11-25)
query stack during panic:
end of query stack
end of query stack
thread 'rustc' panicked at 'Found a `push` without a `pop`.', compiler/rustc_lint/src/levels.rs:504:9
stack backtrace:
   0:     0x7fbe2c719936 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hf5c53e27eabb6c92
   1:     0x7fbe2c787648 - core::fmt::write::h9adcac22ca1ada35
   2:     0x7fbe2c70a9c1 - std::io::Write::write_fmt::hfc1b8644e676f68a
   3:     0x7fbe2c719705 - std::sys_common::backtrace::print::h324c23e4df4fd21b
   4:     0x7fbe2c71cba7 - std::panicking::default_hook::{{closure}}::h0d9f2773bf75edd6
   5:     0x7fbe2c71c906 - std::panicking::default_hook::h0296363bafb07503
   6:     0x56119fabd5df - clippy_driver[8a5d313b41b41c68]::ICE_HOOK::{closure#0}::{closure#0}
   7:     0x7fbe2c71d4d3 - std::panicking::rust_panic_with_hook::h5b6dcf711341e085
   8:     0x7fbe2c71d1c2 - std::panicking::begin_panic_handler::{{closure}}::hc0bcdaae2dbdd5e4
   9:     0x7fbe2c719edc - std::sys_common::backtrace::__rust_end_short_backtrace::hc4161379984d54e2
  10:     0x7fbe2c71ceb2 - rust_begin_unwind
  11:     0x7fbe2c6cf133 - core::panicking::panic_fmt::h03752014e655c065
  12:     0x7fbe2fd933a9 - <rustc_lint[d9358ae84c43d93b]::levels::BuilderPush as core[68faba315474d546]::ops::drop::Drop>::drop
  13:     0x7fbe2d34692d - <rustc_lint[d9358ae84c43d93b]::early::EarlyContextAndPass<rustc_lint[d9358ae84c43d93b]::early::EarlyLintPassObjects> as rustc_ast[a41204963f2f886f]::visit::Visitor>::visit_item
  14:     0x7fbe2d2e900c - rustc_ast[a41204963f2f886f]::visit::walk_crate::<rustc_lint[d9358ae84c43d93b]::early::EarlyContextAndPass<rustc_lint[d9358ae84c43d93b]::early::EarlyLintPassObjects>>
  15:     0x7fbe2d3449ab - rustc_lint[d9358ae84c43d93b]::early::early_lint_node::<rustc_lint[d9358ae84c43d93b]::early::EarlyLintPassObjects, &rustc_ast[a41204963f2f886f]::ast::Crate>
  16:     0x7fbe2d341339 - rustc_lint[d9358ae84c43d93b]::early::check_ast_node::<rustc_lint[d9358ae84c43d93b]::BuiltinCombinedEarlyLintPass, &rustc_ast[a41204963f2f886f]::ast::Crate>
  17:     0x7fbe2d263cda - <rustc_session[255004e973edb88b]::session::Session>::time::<(), rustc_interface[521b6230467a61d]::passes::configure_and_expand::{closure#8}>
  18:     0x7fbe2d2986c6 - rustc_interface[521b6230467a61d]::passes::configure_and_expand
  19:     0x7fbe2d318b5d - <rustc_interface[521b6230467a61d]::queries::Queries>::expansion
  20:     0x7fbe2d1516d5 - <rustc_interface[521b6230467a61d]::interface::Compiler>::enter::<rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}::{closure#2}, core[68faba315474d546]::result::Result<core[68faba315474d546]::option::Option<rustc_interface[521b6230467a61d]::queries::Linker>, rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>
  21:     0x7fbe2d0cb651 - rustc_span[e4d44162dc051c57]::with_source_map::<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_interface[521b6230467a61d]::interface::run_compiler<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}>::{closure#0}::{closure#0}>
  22:     0x7fbe2d152624 - <scoped_tls[a9f52a12973999a]::ScopedKey<rustc_span[e4d44162dc051c57]::SessionGlobals>>::set::<rustc_interface[521b6230467a61d]::interface::run_compiler<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}>::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>
  23:     0x7fbe2d0fab40 - std[97d4460a24a895d5]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[521b6230467a61d]::util::run_in_thread_pool_with_globals<rustc_interface[521b6230467a61d]::interface::run_compiler<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}>::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>
  24:     0x7fbe2d0e0173 - <<std[97d4460a24a895d5]::thread::Builder>::spawn_unchecked_<rustc_interface[521b6230467a61d]::util::run_in_thread_pool_with_globals<rustc_interface[521b6230467a61d]::interface::run_compiler<core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>, rustc_driver[59be94657ff5e7cd]::run_compiler::{closure#1}>::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[68faba315474d546]::result::Result<(), rustc_errors[18491cffa1bdadc5]::ErrorGuaranteed>>::{closure#1} as core[68faba315474d546]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  25:     0x7fbe2c72a1ee - std::sys::unix::thread::Thread::new::thread_start::h583a6f15dd367f1e
  26:     0x7fbe2c3b7b43 - <unknown>
  27:     0x7fbe2c449a00 - <unknown>
  28:                0x0 - <unknown>
error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.


note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.1.67 (3e812cc7 2022-11-25)
query stack during panic:
end of query stack
thread panicked while panicking. aborting.

…p1995 Update Clippy r? `@Manishearth` Sorry for taking so long. There were so many blockers and so little time. This situation should be mitigated with rust-lang#104007 in the future.

bors · 2022-12-17T21:24:27Z

☔ The latest upstream changes (presumably #105827) made this pull request unmergeable. Please resolve the merge conflicts.

flip1995 · 2023-02-10T14:04:18Z

I don't have time for looking into the issue here sadly.. And since I don't want this to get in the way of the other work done about x.py+clippy, I'll close this for now and will get back to it once the other work is done.

matthiaskrgr · 2023-02-10T14:33:15Z

Hm, the asserts are most likely caused by spans of length 0 or spans that point at code segments that don't exist. This causes an ice with debug assertions.
I've seen plenty of these in rustc.
Might be the the internal lints causing them even.

flip1995 · 2023-02-10T14:38:14Z

The issue was mainly that lint messages in internal UI tests were swapped. But I'm currently seeing them flipping around in every other clippy sync... The ICE is expected (used to be an easter egg in Clippy¹ but is now behind the internal feature gate) and tests the ICE message of Clippy. But it seems like this isn't escaped correctly in the Rust CI or something.

When you named a function it_looks_like_you_are_trying_to_kill_clippy Clippy ICEed with the message "Would you like some help with that?" ↩

matthiaskrgr · 2023-02-10T14:47:56Z

Sorry, I mean the

note: Clippy version: clippy 0.1.67 (3e812cc7 2022-11-25)
query stack during panic:
end of query stack
end of query stack
thread 'rustc' panicked at 'Found a `push` without a `pop`.', compiler/rustc_lint/src/levels.rs:504:9
stack backtrace:

one ^^

flip1995 · 2023-02-10T19:34:28Z

That might just be a weird backtrace because we assert(false) during a lint pass 🤔 The actual ICE message is correct.

matthiaskrgr · 2023-02-10T21:13:50Z

Hmm right, this seems to be a different problem.
I tried to mess around with some debug prints but didn't get very far :/

flip1995 added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 5, 2022

rustbot assigned jyn514 Nov 5, 2022

rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2022

jyn514 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2022

jyn514 marked this pull request as ready for review November 5, 2022 14:38

flip1995 mentioned this pull request Nov 21, 2022

Update Clippy #104688

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Nov 24, 2022

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2022

jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2022

flip1995 added 2 commits November 25, 2022 11:43

Fix fallout from Clippy internal features

7391e39

flip1995 force-pushed the clippy-internal-test branch from 075f4c4 to 7391e39 Compare November 25, 2022 11:07

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 25, 2022

flip1995 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2022

flip1995 closed this Feb 10, 2023

flip1995 deleted the clippy-internal-test branch February 10, 2023 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable internal feature when testing Clippy #104007

Enable internal feature when testing Clippy #104007

flip1995 commented Nov 5, 2022

jyn514 commented Nov 5, 2022

jyn514 commented Nov 24, 2022

bors commented Nov 24, 2022

bors commented Nov 25, 2022

This comment has been minimized.

bors commented Nov 25, 2022

rustbot commented Nov 25, 2022

flip1995 commented Nov 25, 2022

rust-log-analyzer commented Nov 25, 2022

bors commented Dec 17, 2022

flip1995 commented Feb 10, 2023

matthiaskrgr commented Feb 10, 2023

flip1995 commented Feb 10, 2023 •

edited

Loading

matthiaskrgr commented Feb 10, 2023

flip1995 commented Feb 10, 2023

matthiaskrgr commented Feb 10, 2023

Enable internal feature when testing Clippy #104007

Enable internal feature when testing Clippy #104007

Conversation

flip1995 commented Nov 5, 2022

jyn514 commented Nov 5, 2022

jyn514 commented Nov 24, 2022

bors commented Nov 24, 2022

bors commented Nov 25, 2022

This comment has been minimized.

bors commented Nov 25, 2022

rustbot commented Nov 25, 2022

flip1995 commented Nov 25, 2022

rust-log-analyzer commented Nov 25, 2022

bors commented Dec 17, 2022

flip1995 commented Feb 10, 2023

matthiaskrgr commented Feb 10, 2023

flip1995 commented Feb 10, 2023 • edited Loading

Footnotes

matthiaskrgr commented Feb 10, 2023

flip1995 commented Feb 10, 2023

matthiaskrgr commented Feb 10, 2023

flip1995 commented Feb 10, 2023 •

edited

Loading