Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve core::ptr::drop_in_place debuginfo #77465

Closed
bjorn3 opened this issue Oct 2, 2020 · 1 comment · Fixed by #79968
Closed

Improve core::ptr::drop_in_place debuginfo #77465

bjorn3 opened this issue Oct 2, 2020 · 1 comment · Fixed by #79968
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Oct 2, 2020

  • Use span of the dropped type as function span when possible.
  • Rename symbol from core::ptr::drop_in_place::<hash> to something like <drop TypeName>::<hash>.
@jonas-schievink jonas-schievink added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2020
@tmiasko
Copy link
Contributor

tmiasko commented Oct 6, 2020

The v0 mangling includes information about generic parameters, e.g., core::ptr::drop_in_place::<alloc::string::String>.

@bjorn3 bjorn3 mentioned this issue Dec 12, 2020
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jan 10, 2021
@JohnTitor
Rollup merge of rust-lang#79968 - bjorn3:better_drop_glue_debuginfo, …
36d8242 
…r=matthewjasper

Improve core::ptr::drop_in_place debuginfo

* Use span of the dropped type as function span when possible.
* Rename symbol from `core::ptr::drop_in_place::$hash` to `{{drop}}::<$TYPE>::$hash`.

Fixes rust-lang#77465

(I haven't yet updated the tests)
@bors bors closed this as completed in f90c7f0 Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve core::ptr::drop_in_place debuginfo bjorn3/rust
3 participants
@jonas-schievink @bjorn3 @tmiasko