-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename libserialize #7098
Comments
@erickt What do you think? |
I'd be fine with this if we also clustered all the concrete encodings in (say) {std, extra}::encoding::* submodules, with a few standard ones like json and xdr, and others left to extra. (mostly for discoverability) |
Note that if you do this, there will be some collision with the need to define character encodings. I believe this was part of the rationale for the current approach. Character encoding has (I think?) a slightly stronger precedent for use of the term than serialization encodings. |
visiting for triage. nominating for backward compat. |
accepted for backwards-compatible |
I prefer |
Since there's another proposed feature for encoding and decoding strings, it may be appropriate to switch back to serialization and deserialization as the terminology here. |
This has moved to |
@erickt Do you have any new opinions on what we should do here? |
@brson: I think using |
Well, I think calling it |
Libcodec, +1
|
I would not assume that something called |
Of course the same is true of |
@erickt If I wanted to rename the |
I'd wait for my redesign. I've finally finished the core of my work, now I'm validating the design by porting toml/msgpack/mustache/etc over to it to validate the design. So hopefully it won't be too long until I'm ready to merge it upstream. |
Nominating for removal from 1.0. If the naming in this lib ends up inconsistent it's not the end of the world (of Rust). The entire lib could also just be experimental for 1.0. |
FWIW, I think it is unlikely that we'll be able to stabilize this library for 1.0, despite it's importance -- especially with significant new design work coming down the pike. |
removing from 1.0 milestone and reassigning as P-low. |
This is no longer relevant with the move of the crate into crates.io. |
Add `cloned_instead_of_copied` lint Don't go cloning all willy-nilly. Featuring a new `get_iterator_item_ty` util! changelog: Add cloned_instead_of_copied lint Closes rust-lang#3870
Since the types are called
Encode
andDecode
, etc. it probably makes sense for the module to reflect this naming, maybe 'encoding' (or 'encodement' 👻 ). Yeah I argued the other way last time. Oh well.The text was updated successfully, but these errors were encountered: