-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't rebuild everything on test-or-comment-only changes #6522
Comments
#2369 would solve this, but in the short term this suggestion is probably a good idea. |
Would #2369 actually solve it? It'd help for stage0, but the other stages always need to be rebuilt, yeah? |
Can we amend this to test-or-docs-only changes? :) |
done :) |
This seems difficult to express via I propose that we table doing this until after we have moved to using |
(i also am deliberately not nominating this for a maturity milestone. I don't see this particular tooling issue as being worth attaching to any particular release; then again, I don't necessarily see that we should put it in at all.) |
I would love for this to happen, but since we're not planning to port all of Rust to rustpkg in the immediate future, it's blocked on #2237 and also far off in the future. |
I've thought about making rustc use workcache internally for compiling individual items, which would address this, but that's also a pretty big project and not an immediate priority. |
Triage: oh yes this is still so very painful. |
This is basically foregone at this point. |
What does that mean?
(Sorry, no native speaker)
|
Translation: this is unlikely to ever happen. |
The current build system makes this pretty much impossible to do. We could technically do it, but it'd be more trouble than it's worth. |
fixes rust-lang#6522 changelog: field_reassign_with_default: don't expand macros in lint suggestion (rust-lang#6522)
field_reassign_with_default: don't expand macros in suggestion fixes rust-lang#6522 changelog: field_reassign_with_default: don't expand macros in lint suggestion (rust-lang#6522)
The build system currently rebuilds everything for test-only changes, which is really painful. Ideally, it should get a diff (using git), and check if any of the changes are outside
#[test]
items before deciding that the build is stale.The text was updated successfully, but these errors were encountered: