Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy-driver no longer builds after rust-lang/rust#61995 #62338

Closed
rust-highfive opened this issue Jul 3, 2019 · 8 comments
Closed

clippy-driver no longer builds after rust-lang/rust#61995 #62338

rust-highfive opened this issue Jul 3, 2019 · 8 comments
Assignees
@rustbot
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

rust-highfive commented Jul 3, 2019 •
edited by rustbot
Loading

Hello, this is your friendly neighborhood mergebot.
After merging PR #61995, I observed that the tool clippy-driver no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rust-clippy is needed to fix the fallout.

cc @eddyb, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @petrochenkov, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2019
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 4, 2019
@matthiaskrgr
submodules: update clippy from e3cb40e to a9f8d3a
7e81295 
Changes:
````
Remove unused import
rustup rust-lang#61995
Fix allow bug in `trivially_copy_pass_by_ref`
readme: fix urls in the license
Fix `match_same_arms` false negative
Reenable cargo and rls tests in travis
Test for melted ICE rust-lang#4121
Fix `never_loop` false positive
Running rustfmt on test
Removed use of intrinsics::uninit from tests.
Making try_err machine applicable
PR comments
Adding try_err lint
````

Fixes rust-lang#62338
@matthiaskrgr matthiaskrgr mentioned this issue Jul 4, 2019
Closed
@pnkfelix
Copy link
Member

pnkfelix commented Jul 4, 2019 •
edited
Loading

triage: P-medium, removing nomination, adding @matthiaskrgr to the assignee list. (Update: couldn't add @matthiaskrgr , so adding self instead.)

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Jul 4, 2019
@pnkfelix pnkfelix self-assigned this Jul 4, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Jul 4, 2019

@rustbot assign @matthiaskrgr

@rustbot rustbot assigned rustbot and unassigned pnkfelix, oli-obk and Manishearth Jul 4, 2019
@tmandry
Copy link
Member

tmandry commented Jul 12, 2019

Ping @matthiaskrgr, are you still working on this?

@matthiaskrgr
Copy link
Member

Er, no.
The current clippy-fix pr is #62613

@tmandry
Copy link
Member

tmandry commented Jul 12, 2019

I wonder if I can do this...
@rustbot assign @lzutao

@matthiaskrgr
Copy link
Member

Issue can be closed now.

@matthiaskrgr
Copy link
Member

@rustbot close

@matthiaskrgr matthiaskrgr mentioned this issue Jul 17, 2019
Closed
@jonas-schievink
Copy link
Contributor

Fixed by #62613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update clippy from e3cb40e4 to a9f8d3a0 matthiaskrgr/rust
8 participants
@pnkfelix @oli-obk @matthiaskrgr @Manishearth @jonas-schievink @tmandry @rust-highfive @rustbot