Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist aes and sha target_features? #44544

Closed
newpavlov opened this issue Sep 13, 2017 · 2 comments · Fixed by #47822
Closed

Whitelist aes and sha target_features? #44544

newpavlov opened this issue Sep 13, 2017 · 2 comments · Fixed by #47822
Labels
C-feature-accepted Category: A feature request that has been accepted pending implementation. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@newpavlov
Copy link
Contributor

newpavlov commented Sep 13, 2017

I would like to use them in the RustCrypto project for conditional compilation. So if there is no particular reason against including them, it would be nice to have them.

This code currently does not work as intended:

#[cfg(target_feature="aes")]
fn main() {
    println!("aes enabled");
}

#[cfg(not(target_feature="aes"))]
fn main() {
    println!("aes disabled");
}

Related: #29717

@Mark-Simulacrum Mark-Simulacrum added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 17, 2017
@Mark-Simulacrum
Copy link
Member

cc @BurntSushi and @alexcrichton

@Mark-Simulacrum Mark-Simulacrum added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Sep 17, 2017
@alexcrichton
Copy link
Member

Seems plausible to me!

@dtolnay dtolnay added C-feature-accepted Category: A feature request that has been accepted pending implementation. and removed C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Nov 14, 2017
kennytm added a commit to kennytm/rust that referenced this issue Jan 29, 2018
Whitelist aes x86 feature flag

Required to fix rust-lang/stdarch#295 in stdsimd.

Closes rust-lang#44544 .

r? @alexcrichton
kennytm added a commit to kennytm/rust that referenced this issue Jan 30, 2018
Whitelist aes x86 feature flag

Required to fix rust-lang/stdarch#295 in stdsimd.

Closes rust-lang#44544 .

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-accepted Category: A feature request that has been accepted pending implementation. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants