Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move futures out of core #2491

Closed
brson opened this issue Jun 3, 2012 · 7 comments
Closed

Move futures out of core #2491

brson opened this issue Jun 3, 2012 · 7 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone

Comments

@brson
Copy link
Contributor

brson commented Jun 3, 2012

futures are not a core type and are only used by the task module. Futures are going to be redesigned to use arcs.

@eholk
Copy link
Contributor

eholk commented Jun 4, 2012

What's the plan for using futures with arcs? I'm not sure I see how arcs help futures.

@brson
Copy link
Contributor Author

brson commented Jun 4, 2012

The problem with current futures is that they are not sendable, so can't be composed in useful, parallel ways. I'm thinking arcs can fix that, though I haven't thought too much about it.

@eholk
Copy link
Contributor

eholk commented Jun 4, 2012

This sounds tricky, since the future object must be mutable.

Since futures run in another task, we could just have get create a port, send a message to the task to send the value back on that port, and continue. We might also tie it to a resource that does ref counting so the task is sure to live long enough. This means get is expensive (it has to create a port), but the future could be send.

@eholk
Copy link
Contributor

eholk commented Aug 6, 2012

I was just reading over this again, and I suspect that futures are now sendable, since they use pipes and pipe endpoints are sendable.

@brson
Copy link
Contributor Author

brson commented Aug 6, 2012

Awesome! That makes them much more useful.

@erickt
Copy link
Contributor

erickt commented Nov 27, 2012

Futures now are in std, so we can close this task according to the title. However, the body also mentions changing futures to use ARCs, which it doesn't use at the moment. Do we still want to make that change, or are using pipes sufficient?

@brson
Copy link
Contributor Author

brson commented Nov 27, 2012

No, I think this is done.

@brson brson closed this as completed Nov 27, 2012
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
fix vscode configuration

Also now that we install rustfmt into the toolchain by default, we no longer need to adjust that command.
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Allow users to skip integration tests by selecting binaries or lib targets.
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
This is a continuation from rust-lang#2491. For completeness, I'm adding --bin option. I've also added a test for these options. Finally, I moved cargo specific arguments to its own module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants