Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for Rust 2024: rustfmt assignment operators rhs indentation #132380

Open
2 of 4 tasks
calebcartwright opened this issue Oct 31, 2024 · 1 comment
Open
2 of 4 tasks
Assignees
Labels
A-edition-2024 Area: The 2024 edition A-rustfmt Area: Rustfmt C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC I-style-nominated Nominated for discussion during a style team meeting. S-tracking-impl-incomplete Status: The implementation is incomplete. T-style Relevant to the style team, which will review and decide on the PR/issue.

Comments

@calebcartwright
Copy link
Member

calebcartwright commented Oct 31, 2024

This is a tracking issue for changing the indentation level used in formatting assignment/op expressions where the left hand side expression has to be formatted across multiple lines, with the style/formatting changing to indent the right hand side expression relative to the last line of the left hand side expression

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

None.

Implementation history

cc @rust-lang/rustfmt @rust-lang/style

@calebcartwright calebcartwright added A-edition-2024 Area: The 2024 edition A-rustfmt Area: Rustfmt C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC I-style-nominated Nominated for discussion during a style team meeting. S-tracking-impl-incomplete Status: The implementation is incomplete. S-tracking-needs-documentation Status: Needs documentation. T-style Relevant to the style team, which will review and decide on the PR/issue. labels Oct 31, 2024
@calebcartwright
Copy link
Member Author

the Style and Rustfmt teams are already aware of this, but given the late date I will note for transparency that we do already have this "implemented" in rustfmt and have been doing some testing on it (and it's that testing that surfaced some formatting diffs that led to us winding back the operators where the new rule should be applied).

I am intentionally going to keep the impl-incomplete label here though until we get the PR merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2024 Area: The 2024 edition A-rustfmt Area: Rustfmt C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC I-style-nominated Nominated for discussion during a style team meeting. S-tracking-impl-incomplete Status: The implementation is incomplete. T-style Relevant to the style team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants