Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: add max-llvm-major-version directive #132305

Closed
jieyouxu opened this issue Oct 29, 2024 · 0 comments · Fixed by #132310
Closed

compiletest: add max-llvm-major-version directive #132305

jieyouxu opened this issue Oct 29, 2024 · 0 comments · Fixed by #132310
Assignees
@jieyouxu
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Oct 29, 2024 •
edited
Loading

compiletest already has support for

  • //@ ignore-llvm-version: 20 - 99, and
  • //@ min-llvm-version: 20

but here ignore-llvm-version really means max-llvm-major-version: 19.

See #132266 (comment).
@jieyouxu jieyouxu added A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 29, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 29, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 29, 2024
@jieyouxu jieyouxu changed the title compiletest: add min-llvm-version directive compiletest: add max-llvm-version directive Oct 29, 2024
@jieyouxu jieyouxu self-assigned this Oct 29, 2024
@jieyouxu jieyouxu mentioned this issue Oct 29, 2024
Merged
2 tasks
@jieyouxu jieyouxu changed the title compiletest: add max-llvm-version directive compiletest: add max-llvm-major-version directive Nov 13, 2024
@bors bors closed this as completed in 475203f Nov 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 14, 2024
@rust-timer
Unrolled build for rust-lang#132310
6271b7b 
Rollup merge of rust-lang#132310 - jieyouxu:max-llvm-version, r=onur-ozkan

compiletest: add `max-llvm-major-version` directive

To complement existing `min-llvm-version` so contributors don't have to use `ignore-llvm-version: 20 - 99` to emulate `max-llvm-major-version: 19`.

Closes rust-lang#132305.
cc `@workingjubilee` who suggested this.

### Implementation steps

- [x] 1. Implement the directive (this PR)
- [x] 2. Open an accompanying dev-guide PR to describe the directive (rust-lang/rustc-dev-guide#2129)

r? bootstrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
compiletest maintenance and improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compiletest: add max-llvm-major-version directive jieyouxu/rust
2 participants
@jieyouxu @rustbot