Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy requires src/tools/rustc-perf? #126559

Closed
matthiaskrgr opened this issue Jun 16, 2024 · 2 comments
Closed

tidy requires src/tools/rustc-perf? #126559

matthiaskrgr opened this issue Jun 16, 2024 · 2 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

I did an x.py test crashes which went find, when I did a x.py test crashes tidy afterwards, it seems like that caused rustc-perf to be initially pulled into the repo 🤔 as if it was a dependency for running tidy?? 🤔 🤔

    Finished `dev` profile [unoptimized] target(s) in 0.03s
Updating submodule src/tools/rustc-perf
Submodule 'src/tools/rustc-perf' (https://github.com/rust-lang/rustc-perf.git) registered for path 'src/tools/rustc-perf'
Cloning into '/home/matthias/vcs/github/rust/src/tools/rustc-perf'...
remote: Enumerating objects: 7900, done.
remote: Counting objects: 100% (7900/7900), done.
remote: Compressing objects: 100% (5222/5222), done.
remote: Total 7900 (delta 2588), reused 6415 (delta 2492), pack-reused 0
Receiving objects: 100% (7900/7900), 28.05 MiB | 6.42 MiB/s, done.
Resolving deltas: 100% (2588/2588), done.
Submodule path 'src/tools/rustc-perf': checked out 'c64bb60dd1636922b1ccbb82867bed934a99dbcb'
Building stage0 tool tidy (x86_64-unknown-linux-gnu)
   Compiling proc-macro2 v1.0.85
   Compiling unicode-ident v1.0.12
   Compiling memchr v2.5.0
   Compiling serde v1.0.203
@matthiaskrgr matthiaskrgr added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 16, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 16, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Jun 16, 2024

See #126224 and its hotfix #126225. #126230 is improving this to avoid having to checkout rustc-perf in non-CI environments (looks ready and is waiting fo review).

@jieyouxu jieyouxu added C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 16, 2024
@onur-ozkan
Copy link
Member

Closing as #126230 is landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

4 participants