Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy error: rustc-perf workspace doesn't have a Cargo.lock #126224

Closed
jieyouxu opened this issue Jun 10, 2024 · 0 comments · Fixed by #126225
Closed

tidy error: rustc-perf workspace doesn't have a Cargo.lock #126224

jieyouxu opened this issue Jun 10, 2024 · 0 comments · Fixed by #126225
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Jun 10, 2024 •
edited
Loading

Tidy check (x test tidy) currently fails with

tidy error: the `src/tools/rustc-perf` workspace doesn't have a Cargo.lock

If you don't have rustc-perf submodule initialized.

Temporary workaround

git submodule update --init --recursive
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Jun 10, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 10, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 10, 2024
@Kobzol Kobzol mentioned this issue Jun 10, 2024
Merged
@bors bors closed this as completed in 0de24a5 Jun 10, 2024
@jieyouxu jieyouxu mentioned this issue Jun 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update rustc-perf submodule before running tidy Kobzol/rust
2 participants
@jieyouxu @rustbot