Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace various intrinsic wrappers with intrinsic reexports #12634

Closed
brson opened this issue Feb 28, 2014 · 6 comments
Closed

Replace various intrinsic wrappers with intrinsic reexports #12634

brson opened this issue Feb 28, 2014 · 6 comments
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 28, 2014

Alternative strategy to #10008, depends on #10725 and #12633.

rustc spends a lot of time inlining intrinsic wrappers, and in debug mode they cause a lot of code bloat. Once intrinsics behave more like real functions we can use reexports to get rid of the wrappers.
@huonw
Copy link
Member

huonw commented Jul 4, 2014

I believe this is (implicitly) the tracking issue for RFC 5? (Tagged with B-RFC-approved, remove it if I'm wrong.)

@huonw huonw mentioned this issue Jul 4, 2014
Closed
@brson
Copy link
Contributor Author

brson commented Jul 4, 2014

Yep.

@brson
Copy link
Contributor Author

brson commented Jul 4, 2014

This could reduce rustc memory usage measurably.

This was referenced Jul 4, 2014
Closed
Closed
@steveklabnik
Copy link
Member

Triage: issue link is https://github.com/rust-lang/rfcs/blob/master/text/0008-new-intrinsics.md

@steveklabnik
Copy link
Member

Triage: rust-intrinsic still exists

@alexcrichton alexcrichton added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 11, 2015
@brson
Copy link
Contributor Author

brson commented Jun 10, 2016

Original RFC is dead. Issue is quite obsolete.

@brson brson closed this as completed Jun 10, 2016
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12634 - iDawer:match-check.witnesses, r=flodi…
6420840 
…ebold

feat: Show witnesses of non-exhaustiveness in `missing-match-arm` diagnostic

Shamelessly copied from rustc. Thus reporting format is same.

This extends public api  `hir::diagnostics::MissingMatchArms` with `uncovered_patterns: String` field. It does not expose data for implementing a quick fix yet.

-----
Worth to note: current implementation does not give a comprehensive list of missing patterns. Also mentioned in [paper](http://moscova.inria.fr/~maranget/papers/warn/warn.pdf):

> One may think that algorithm I should make an additional effort to provide more
> non-matching values, by systematically computing recursive calls on specialized
> matrices when possible, and by returning a list of all pattern vectors returned by
> recursive calls. We can first observe that it is not possible in general to supply the
> users with all non-matching values, since the signature of integers is (potentially)
> infinite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @alexcrichton @brson @huonw @thestinger