Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devise a way to test spans #12182

Closed
sanxiyn opened this issue Feb 11, 2014 · 4 comments
Closed

Devise a way to test spans #12182

sanxiyn opened this issue Feb 11, 2014 · 4 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@sanxiyn
Copy link
Member

sanxiyn commented Feb 11, 2014

There are minimal tests in libsyntax unit tests, but they are 1. nowhere near comprehensive, 2. extremely painful to read and write.
@steveklabnik steveklabnik added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Apr 16, 2015
@sanxiyn
Copy link
Member Author

sanxiyn commented Aug 16, 2016

UI test (added in #33588) can test spans now.

Still, I think UI test can't test spans not used by diagnostics. Such spans can still affect rustfmt, for example.

@estebank estebank mentioned this issue Nov 15, 2016
Merged
@steveklabnik
Copy link
Member

Triage: not aware of any changes

@estebank
Copy link
Contributor

estebank commented Nov 7, 2018

Current status:

  • We have a way to test spans visual output
  • We have a way to test the UI output for the entire test suite
  • We have a way to test the code generated from applying suggestions (.fixed test files when adding // run-rustfix to test file)

@steveklabnik @sanxiyn do you think we can close this ticket given this?

@steveklabnik
Copy link
Member

Sounds good to me. Let's close! <3

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12281 - lnicola:increase-overflow-depth, r=ln…
65a213c 
…icola

Increase defalt chalk overflow depth to match max solver size

TBC:

 - rust-lang#12279: ok above 480
 - ~~rust-lang#12182~~
 - ~~rust-lang#12095~~
 - rust-lang#11902: ok above 350
 - ~~rust-lang#11668~~
 - rust-lang#11370: ok above 450
 - rust-lang#9754: probably ok above 250 (!), and the code in cause and branch are gone

Closes rust-lang#12279
Closes rust-lang#11902
Closes rust-lang#11370
Closes rust-lang#9754
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 25, 2024
@bors
Auto merge of rust-lang#12183 - y21:issue12182, r=dswij
0b6e7e2 
respect `#[allow]` attributes in `single_call_fn` lint

Fixes rust-lang#12182

If we delay linting to `check_crate_post`, we need to use `span_lint_hir_and_then`, since otherwise it would only respect those lint level attributes at the crate root.
<sub>... maybe we can have an internal lint for this somehow?</sub>

changelog: respect `#[allow]` attributes in `single_call_fn` lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @sanxiyn @estebank