Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should report unused_import when it reexports nothing #116032

Closed
bvanjoi opened this issue Sep 21, 2023 · 0 comments · Fixed by #116033
Closed

should report unused_import when it reexports nothing #116032

bvanjoi opened this issue Sep 21, 2023 · 0 comments · Fixed by #116033
Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bvanjoi
Copy link
Contributor

bvanjoi commented Sep 21, 2023

Code

mod a {}

pub use a::*;

fn main() {}

Current output

nothing

Desired output

unused import: `a::*`

Rationale and extra context

No response

Other cases

No response

Anything else?

No response
@bvanjoi bvanjoi added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 21, 2023
@bvanjoi bvanjoi mentioned this issue Sep 21, 2023
Merged
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 21, 2023
@saethlin saethlin changed the title should report unsed_import when it reexports nothing should report unused_import when it reexports nothing Sep 22, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 15, 2023
@matthiaskrgr
Rollup merge of rust-lang#116033 - bvanjoi:fix-116032, r=petrochenkov
8a2877b 
report `unused_import` for empty reexports even it is pub

Fixes rust-lang#116032

An easy fix. r? `@petrochenkov`

(Discovered this issue while reviewing rust-lang#115993.)
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 16, 2023
@bors
Auto merge of rust-lang#116033 - bvanjoi:fix-116032, r=petrochenkov
37b432a 
report `unused_import` for empty reexports even it is pub

Fixes rust-lang#116032

An easy fix. r? `@petrochenkov`

(Discovered this issue while reviewing rust-lang#115993.)
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 19, 2023
@bors
Auto merge of rust-lang#116033 - bvanjoi:fix-116032, r=petrochenkov
f99fa3d 
report `unused_import` for empty reexports even it is pub

Fixes rust-lang#116032

An easy fix. r? `@petrochenkov`

(Discovered this issue while reviewing rust-lang#115993.)
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 20, 2023
@bors
Auto merge of rust-lang#116033 - bvanjoi:fix-116032, r=petrochenkov
8e13493 
report `unused_import` for empty reexports even it is pub

Fixes rust-lang#116032

An easy fix. r? `@petrochenkov`

(Discovered this issue while reviewing rust-lang#115993.)
@bors bors closed this as completed in 41aa06e Oct 23, 2023
flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 2, 2023
@bors
Auto merge of rust-lang#116033 - bvanjoi:fix-116032, r=petrochenkov
330d7fa 
report `unused_import` for empty reexports even it is pub

Fixes rust-lang#116032

An easy fix. r? `@petrochenkov`

(Discovered this issue while reviewing rust-lang#115993.)
calebcartwright pushed a commit to calebcartwright/rust that referenced this issue Jun 22, 2024
@bors
Auto merge of rust-lang#116033 - bvanjoi:fix-116032, r=petrochenkov
d5bf53b 
report `unused_import` for empty reexports even it is pub

Fixes rust-lang#116032

An easy fix. r? `@petrochenkov`

(Discovered this issue while reviewing rust-lang#115993.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

report unused_import for empty reexports even it is pub bvanjoi/rust
3 participants
@saethlin @bvanjoi @rustbot