Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msrv config for map_clone #8280

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Jan 14, 2022

Just a small PR to have some fun with Clippy and to clear my head a bit 😅


changelog: [map_clone]: The suggestion takes msrv into account
changelog: Track msrv attribute for manual_bits and borrow_as_prt

fixes: #8276

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 14, 2022
@flip1995
Copy link
Member

(full review follows soon)

@xFrednet xFrednet force-pushed the 8276-map-clone-msrv branch from e4eba9a to 5507f1f Compare January 14, 2022 23:54
@xFrednet xFrednet force-pushed the 8276-map-clone-msrv branch from 5507f1f to 1afeb71 Compare January 14, 2022 23:57
@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2022

📌 Commit 1afeb71 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jan 19, 2022

⌛ Testing commit 1afeb71 with merge 8bb4690...

@bors
Copy link
Contributor

bors commented Jan 19, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8bb4690 to master...

@bors bors merged commit 8bb4690 into rust-lang:master Jan 19, 2022
@xFrednet xFrednet deleted the 8276-map-clone-msrv branch January 19, 2022 17:05
bors added a commit that referenced this pull request Mar 1, 2022
Implement internal lint for MSRV lints

This internal lint checks if the `extract_msrv_attrs!` macro is used if
a lint has a MSRV. If not, it suggests to add this attribute to the lint
pass implementation.

Following up #8280 (comment). This currently doesn't implement the documentation check. But since this is just an extension of this lint, I think this is a good MVP of this lint.

r? `@camsteffen`

cc `@xFrednet`

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map_clone doesn't respect MSRV for copied
5 participants