Cleaner code for unsep literals

[tesuji]

Continuing discussion in #4401 (comment)
changelog: none
r? @flip1995

[flip1995]

This code looks way cleaner than before, thanks!

What about the problem with the assert you mentioned in the other PR?

[flip1995]

What about the problem with the assert you mentioned in the other PR?

Ah just saw it in the travis build. That's a really weird macro interaction 😄

Can you add a check for span.in_external_macro(). This should solve this issue. Can you also try to reproduce this behavior with a custom written macro?

[flip1995]

I think it's because of the line! macro. Can you add a test for it?

[tesuji]

Can you add a check for span.in_external_macro().

It already have that check in

rust-clippy/clippy_lints/src/misc_early.rs

Lines 319 to 322 in 0ccb9ea

	fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) {
	if in_external_macro(cx.sess(), expr.span) {
	return;
	}

but it doesn't work as it seems.

I think it's because of the line! macro. Can you add a test for it?

👍

[flip1995]

I think the in_external_macro check should stay. You should be able to add a check for this with the auxiliary files in the ui test directory.

[tesuji]

Tests passed locally.
I cannot find a way to detect line!() macro. Maybe it is eager expansion by compiler?

[flip1995]

That's a good solution for the line problem. Only 2 more things left and this can be merged

[tesuji]

I resolved comment review. Thank you very much for your help!

[flip1995]

Thanks!

@bors r+

[bors]

📌 Commit c1a4b26 has been approved by flip1995

[bors]

⌛ Testing commit c1a4b26 with merge b8e5e6f...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing b8e5e6f to master...