-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miri script: build with stable toolchain #3402
Conversation
@bors r+ |
miri script: build with stable toolchain `./miri toolchain` sets up a `rustup override miri`. But then if something goes wrong and the `miri` toolchain doesn't work, one can't even run `./miri toolchain` again as building miri-script needs a toolchain... So let's always use stable to build miri-script, making it override-independent. I assume everyone will have that installed.
Why would this PR cause that test to fail on Windows...?!?
We are running our entire CI in bash.^^ But now somehow this one |
That could happen if it's picking up the bash in the system directory. Maybe use |
💔 Test failed - checks-actions |
I'll try that, thanks. But why does adding |
@bors r+ |
miri script: build with stable toolchain `./miri toolchain` sets up a `rustup override miri`. But then if something goes wrong and the `miri` toolchain doesn't work, one can't even run `./miri toolchain` again as building miri-script needs a toolchain... So let's always use stable to build miri-script, making it override-independent. I assume everyone will have that installed.
|
@bors r+ |
miri script: build with stable toolchain `./miri toolchain` sets up a `rustup override miri`. But then if something goes wrong and the `miri` toolchain doesn't work, one can't even run `./miri toolchain` again as building miri-script needs a toolchain... So let's always use stable to build miri-script, making it override-independent. I assume everyone will have that installed.
What is even going on?
So here,
|
5a389cd
to
4d1e030
Compare
Looks like they are using 1.76. Let's see if 1.77 fixes this... after all we've been using miri-script for a while now (but with nightly Rust) and it always worked on Windows. @bors r+ |
This comment was marked as outdated.
This comment was marked as outdated.
@bors r+ |
miri script: build with stable toolchain `./miri toolchain` sets up a `rustup override miri`. But then if something goes wrong and the `miri` toolchain doesn't work, one can't even run `./miri toolchain` again as building miri-script needs a toolchain... So let's always use stable to build miri-script, making it override-independent. I assume everyone will have that installed.
miri script: build with stable toolchain `./miri toolchain` sets up a `rustup override miri`. But then if something goes wrong and the `miri` toolchain doesn't work, one can't even run `./miri toolchain` again as building miri-script needs a toolchain... So let's always use stable to build miri-script, making it override-independent. I assume everyone will have that installed.
Nope, latest stable is still affected. |
Hm, something doesn't make sense. We've been using this for at least 7 months now. Whatever was the nightly back then, has long reached stable. So this can't be just a difference between Rust stable vs nightly. It has to be that somehow adding the |
Well, hard-coding the path seems to work. 🤷 @bors r+ |
miri script: build with stable toolchain `./miri toolchain` sets up a `rustup override miri`. But then if something goes wrong and the `miri` toolchain doesn't work, one can't even run `./miri toolchain` again as building miri-script needs a toolchain... So let's always use stable to build miri-script, making it override-independent. I assume everyone will have that installed.
Yeah something is definitely patching the env var -- but only if it is not surrounded by
|
Seems to be this functionality that reportedly is specific to Git-for-Windows. What remains completely unclear is why adding the |
@bors r+ |
☀️ Test successful - checks-actions |
./miri toolchain
sets up arustup override miri
. But then if something goes wrong and themiri
toolchain doesn't work, one can't even run./miri toolchain
again as building miri-script needs a toolchain...So let's always use stable to build miri-script, making it override-independent. I assume everyone will have that installed.