Fix backwards cmpxchg_weak_failure_rate check
#2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
May 7, 2022
|
Ah this is why crossbeam had to set |
cbeuw
reviewed
May 8, 2022
RalfJung
added
the
S-waiting-on-author
|
@bors r+ |
|
📌 Commit fdfbd7a has been approved by |
|
This reminds me, is there some test we could add for this? |
|
☀️ Test successful - checks-actions |
6 tasks
|
Added a test in #2148 |
bors
added a commit
that referenced
this pull request
May 23, 2022
…t, r=RalfJung test that compare-exchange-weak-failure-rate=0.0 means what it says Adds a test for #2105
bors bot
added a commit
to crossbeam-rs/crossbeam
that referenced
this pull request
May 31, 2022
843: Fix miri tests r=taiki-e a=alygin There were several changes in Miri recently, including [breaking ones](rust-lang/miri#2105) and affecting its speed. They caused CI builds failures. This fix makes the most expensive Miri tests less intensive, so they have decent execution time again. Co-authored-by: Andrew Lygin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh, I guess I got this backwards a long time ago 😓.