Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print hex dump of alloc on reading undef bytes #1354

Merged
merged 5 commits into from
Apr 27, 2020
Merged

Print hex dump of alloc on reading undef bytes #1354

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e37d0e3
Print hex dump of alloc on reading undef bytes
divergentdave Apr 22, 2020
9057dae
Reorder output
divergentdave Apr 22, 2020
d9ac84d
Add message before dumping alloc
divergentdave Apr 24, 2020
7f92eab
Add test to exercise InvalidUndefBytes
divergentdave Apr 24, 2020
e267fb4
Review comments
divergentdave Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ pub fn report_error<'tcx, 'mir>(
};

e.print_backtrace();
if let UndefinedBehavior(UndefinedBehaviorInfo::InvalidUndefBytes(Some(ptr))) = e.kind {
RalfJung marked this conversation as resolved.
Show resolved Hide resolved
ecx.memory.dump_alloc(ptr.alloc_id);
}
RalfJung marked this conversation as resolved.
Show resolved Hide resolved
let msg = e.to_string();
report_msg(ecx, &format!("{}: {}", title, msg), msg, helps, true)
}
Expand Down