Skip to content

Commit

Permalink
Auto merge of #116849 - oli-obk:error_shenanigans, r=cjgillot
Browse files Browse the repository at this point in the history
Avoid a `track_errors` by bubbling up most errors from `check_well_formed`

I believe `track_errors` is mostly papering over issues that a sufficiently convoluted query graph can hit. I made this change, while the actual change I want to do is to stop bailing out early on errors, and instead use this new `ErrorGuaranteed` to invoke `check_well_formed` for individual items before doing all the `typeck` logic on them.

This works towards resolving rust-lang/rust#97477 and various other ICEs, as well as allowing us to use parallel rustc more (which is currently rather limited/bottlenecked due to the very sequential nature in which we do `rustc_hir_analysis::check_crate`)

cc `@SparrowLii` `@Zoxc` for the new `try_par_for_each_in` function
  • Loading branch information
bors committed Oct 23, 2023
2 parents fbfffdd + ccfd5bb commit 985a9f9
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 985a9f9

Please sign in to comment.