Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer existing IP address methods from ipcheck #312

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jstasiak
Copy link
Contributor

@jstasiak jstasiak commented Dec 7, 2023

The is_unicast_site_local() method has been gone since Rust 1.55[1] and is_ietf_protocol_assignment() since 1.56[2].

I had to run this tool to test something, saw it wouldn't build with
modern Rust and thought I'd submit a patch.

[1] rust-lang/rust#85820
[2] rust-lang/rust#86439

The is_unicast_site_local() method has been gone since Rust 1.55[1] and
is_ietf_protocol_assignment() since 1.56[2].

I had to run this tool to test something, saw it wouldn't build with
modern Rust.

[1] rust-lang/rust#85820
[2] rust-lang/rust#86439
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 96018ed into rust-lang:main Dec 7, 2023
@jstasiak jstasiak deleted the make-ipcheck-build-again branch December 15, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants