Fix usage with rustc-dep-of-std
#4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
tgross35
force-pushed
the
fix-rustc-dep-of-std
branch
from
2bc429b to
eaf8c21
Compare
|
I'm going to wait for #4161 and then do the remaining fixes on top of that. |
tgross35
force-pushed
the
fix-rustc-dep-of-std
branch
2 times, most recently
from
eee0977 to
b1a7f91
Compare
|
☔ The latest upstream changes (presumably #4161) made this pull request unmergeable. Please resolve the merge conflicts. |
tgross35
force-pushed
the
fix-rustc-dep-of-std
branch
from
214a5f0 to
233684f
Compare
tgross35
force-pushed
the
fix-rustc-dep-of-std
branch
5 times, most recently
from
6087fbc to
cfa7ce0
Compare
tgross35
force-pushed
the
fix-rustc-dep-of-std
branch
from
cfa7ce0 to
f3b5b4c
Compare
tgross35
added
the
stable-nominated
Since [1] we use derive macros rather than manually implementing `Clone` and `Copy`. However, this caused the build in `std` to start failing since the `core` prelude is not available. This provides the derive macros as well as `derive` itself. Resolve this by using complete paths. Additionally allow `internal_features` to suppress the warning using `link_cfg`, and change to using global paths for all uses of `core`. Link: rust-lang#4038 [1]
Add a test that the crate builds correctly with the configuration that is used in `std`.
tgross35
force-pushed
the
fix-rustc-dep-of-std
branch
from
1d7caa7 to
9839a9a
Compare
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 28, 2024
Since [1] we use derive macros rather than manually implementing `Clone` and `Copy`. However, this caused the build in `std` to start failing since the `core` prelude is not available. This provides the derive macros as well as `derive` itself. Resolve this by using complete paths. Additionally allow `internal_features` to suppress the warning using `link_cfg`, and change to using global paths for all uses of `core`. Link: rust-lang#4038 [1] (backport <rust-lang#4158>) (cherry picked from commit d69ad56)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 28, 2024
Add a test that the crate builds correctly with the configuration that is used in `std`. (backport <rust-lang#4158>) (cherry picked from commit 9839a9a)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #4038 we use derive macros rather than manually implementing
Cloneand
Copy. However, this caused the build instdto start failing since thecoreprelude is not available. This provides the derive macros as well asderiveitself.Resolve this by using complete paths. Additionally allow
internal_featuresto suppress the warning usinglink_cfg.Includes a test that verifies build with
rustc-dep-of-stdenabled.