Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use qemu-sparc64 to run sparc64 tests #4133

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

folkertdev
Copy link
Contributor

fixes #4061

Description

uses qemu-sparc64 to run the sparc64 tests. That is (for some reason) much faster than the test-runner-linux script that uses qemu-system-sparc64 under the hood. It runs the test suite locally in ~3 minutes, similar to the other targets.

I added some things to make this work, I'm not sure if other things should be removed that are now no longer needed.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

r? @tgross35

@folkertdev
Copy link
Contributor Author

on CI it's 4:45 ish, still pretty good, and no longer the bottleneck for CI.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is a wonderful improvement, thanks for working on it!

@tgross35 tgross35 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into rust-lang:main with commit 294a882 Nov 22, 2024
45 checks passed
@tgross35
Copy link
Contributor

Merged in 15 minutes, awesome improvement

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 23, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 23, 2024
(backport <rust-lang#4133>)
(cherry picked from commit e580f56)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do something about the sparc CI job
3 participants