Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set -u (error on unset) in all script files #4108

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Set -u (error on unset) in all script files #4108

merged 3 commits into from
Nov 18, 2024

Conversation

tgross35
Copy link
Contributor

This is a pretty common flag to reduce errors. Make use of it here.

@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 marked this pull request as ready for review November 18, 2024 20:49
@tgross35
ci: Set -u (error on unset) in all script files
59a18de 
This is a pretty common flag to reduce errors. Make use of it here.
@tgross35 tgross35 force-pushed the set-u branch 5 times, most recently from d76aa65 to 0452fe6 Compare November 18, 2024 20:58
@tgross35 tgross35 enabled auto-merge November 18, 2024 21:03
@tgross35 tgross35 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into rust-lang:main with commit f92da8e Nov 18, 2024
44 checks passed
@tgross35 tgross35 deleted the set-u branch November 18, 2024 22:44
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 19, 2024
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 19, 2024
@tgross35
ci: Set -u (error on unset) in all script files
18181ec 
This is a pretty common flag to reduce errors. Make use of it here.

(backport <rust-lang#4108>)
(cherry picked from commit 59a18de)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 19, 2024
@tgross35
ci: Fix cases where unset variables cause errors
759adaf 
(backport <rust-lang#4108>)
(cherry picked from commit f3bb382)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 19, 2024
@tgross35
ci: fix indentation in one more place
43fe4a0 
(backport <rust-lang#4108>)
(cherry picked from commit 331dd50)
@tgross35 tgross35 mentioned this pull request Nov 19, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgross35 @rustbot @JohnTitor