[main] Drop the libc_const_extern_fn conditional
#4105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
tgross35
force-pushed
the
remove-cfg-const-extern-fn-main
branch
3 times, most recently
from
015a53e to
7cd141a
Compare
tgross35
force-pushed
the
remove-cfg-const-extern-fn-main
branch
2 times, most recently
from
9e7c600 to
b1de7a2
Compare
Additionally deprecate the `const-extern-fn` feature. This is possible since the MSRV was increased to 1.63. (apply <rust-lang#4063> to `main`) (cherry picked from commit 674cc1f)
tgross35
force-pushed
the
remove-cfg-const-extern-fn-main
branch
from
b1de7a2 to
fa554bc
Compare
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 26, 2024
In [1] this conditional was dropped in favor of a Cargo feature, which was turned on by default in [2]. Fixes: rust-lang#4149 [1]: rust-lang#4105 [2]: rust-lang#4134
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 26, 2024
In [1] this conditional was dropped in favor of a Cargo feature, which was turned on by default in [2]. Fixes: rust-lang#4149 [1]: rust-lang#4105 [2]: rust-lang#4134
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 26, 2024
In [1] this conditional was dropped in favor of a Cargo feature, which was turned on by default in [2]. However, this did not help the case where `--no-default-features` is passed. Unfortunately we still can't drop this config entirely since `ctest` cannot parse the syntax, so change back to useing a `cfg` to control constness rather than a Cargo feature. Fixes: rust-lang#4149 [1]: rust-lang#4105 [2]: rust-lang#4134
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 26, 2024
In [1] this conditional was dropped in favor of a Cargo feature, which was turned on by default in [2]. However, this did not help the case where `--no-default-features` is passed. Unfortunately we still can't drop this config entirely since `ctest` cannot parse the syntax, so change back to useing a `cfg` to control constness rather than a Cargo feature. Additionally, remove a portion of the macro's comment that is no longer relevant. Fixes: rust-lang#4149 [1]: rust-lang#4105 [2]: rust-lang#4134
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 26, 2024
In [1] this conditional was dropped in favor of a Cargo feature, which was turned on by default in [2]. However, this did not help the case where `--no-default-features` is passed. Unfortunately we still can't drop this config entirely since `ctest` cannot parse the syntax, so change back to useing a `cfg` to control constness rather than a Cargo feature. Additionally, remove a portion of the macro's comment that is no longer relevant. Fixes: rust-lang#4149 [1]: rust-lang#4105 [2]: rust-lang#4134 (backport <rust-lang#4151>) (cherry picked from commit e18ee8c)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 26, 2024
In [1] this conditional was dropped in favor of a Cargo feature, which was turned on by default in [2]. However, this did not help the case where `--no-default-features` is passed. Unfortunately we still can't drop this config entirely since `ctest` cannot parse the syntax, so change back to useing a `cfg` to control constness rather than a Cargo feature. Additionally, remove a portion of the macro's comment that is no longer relevant. Fixes: rust-lang#4149 [1]: rust-lang#4105 [2]: rust-lang#4134 (backport <rust-lang#4151>) (cherry picked from commit e18ee8c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally deprecate the
const-extern-fnfeature. This is possible since the MSRV was increased to 1.63.(apply #4063 to
main)(cherry picked from commit 674cc1f)