ci: make scripts more uniform #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
tgross35
force-pushed
the
uniform-scripts
branch
from
f88b5e0 to
897508b
Compare
tgross35
added
the
stable-nominated
tgross35
force-pushed
the
uniform-scripts
branch
from
c170523 to
b4fc8e4
Compare
Perform the following style changes:
- Only use uppercase variable names if they are exported
- Only use `${...}` syntax when joining with other strings, `$...`
otherwise
- Use `CARGO_TERM_VERBOSE` rather than always passing `-v`
- Indent is always four spaces
- Fix shellcheck errors in all shell scripts
- Rewrap some long or complex commands
- Replace redundant `| \` with just `|`
tgross35
force-pushed
the
uniform-scripts
branch
from
b4fc8e4 to
4230b41
Compare
tgross35
added
stable-blocked
and removed
stable-nominated
This was referenced Nov 16, 2024
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 16, 2024
Perform the following style changes:
- Only use uppercase variable names if they are exported
- Only use `${...}` syntax when joining with other strings, `$...`
otherwise
- Use `CARGO_TERM_VERBOSE` rather than always passing `-v`
- Indent is always four spaces
- Fix shellcheck errors in all shell scripts
- Rewrap some long or complex commands
- Replace redundant `| \` with just `|`
(backport <rust-lang#4042>)
(cherry picked from commit eddb526)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 16, 2024
(backport <rust-lang#4042>) (cherry picked from commit 4230b41)
Merged
tgross35
added
stable-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform the following style changes:
${...}syntax when joining with other strings,$...otherwiseCARGO_TERM_VERBOSErather than always passing-v