Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build on armv7-unknown-freebsd #3994

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix the build on armv7-unknown-freebsd #3994

merged 1 commit into from
Oct 21, 2024

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Oct 21, 2024

PR #3848 broke the build on avm7-unknown-freebsd by defining a field to be of an unknown type. Use the correct type name usize instead of ::size_t.

@asomers
Fix the build on armv7-unknown-freebsd
816b524 
PR rust-lang#3848 broke the build on armv7-unknown-freebsd by defining a field to
be of an unknown type.  Use the correct type name `usize` instead of
`::__size_t`.
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@asomers
Copy link
Contributor Author

asomers commented Oct 21, 2024

cc @tgross35

tgross35
tgross35 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding and for the fix.

@tgross35 tgross35 enabled auto-merge October 21, 2024 20:55
@tgross35
Copy link
Contributor

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 21, 2024
@tgross35 tgross35 added this pull request to the merge queue Oct 21, 2024
Merged via the queue into rust-lang:main with commit b667ac1 Oct 21, 2024
41 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 7, 2024
@asomers @tgross35
Fix the build on armv7-unknown-freebsd
c0c9391 
PR rust-lang#3848 broke the build on armv7-unknown-freebsd by defining a field to
be of an unknown type.  Use the correct type name `usize` instead of
`::__size_t`.

(backport <rust-lang#3994>)
(cherry picked from commit 816b524)
@tgross35 tgross35 mentioned this pull request Nov 7, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asomers @rustbot @tgross35 @JohnTitor