Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pthread constants and functions for VxWorks #3963

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

biabbas
Copy link
Contributor

@biabbas biabbas commented Oct 14, 2024

Changes made are supporting changes for iddm/thread-priority#45

  1. Changes name of sched_param in VxWorks so that it matches unix platforms
  2. Add pthread constants and functions required for thread-priority.

Requesting for stable nomination.

r? @tgross35

Thank you,
B I Mohammed Abbas

@biabbas biabbas force-pushed the vxworks_threads branch 6 times, most recently from 722db94 to b5d9955 Compare October 14, 2024 12:12
@tgross35
Copy link
Contributor

Thanks for the PR, could you provide links to headers or manpages? Or at least copy+paste the relevant bits of the headers you are testing against to the PR description.

@biabbas biabbas force-pushed the vxworks_threads branch 2 times, most recently from 998bbf6 to 03ab995 Compare October 16, 2024 03:56
@tgross35
Copy link
Contributor

Do you have links to headers / docs to check against?

Also FYI the commit summary only says "VxWorks"

@biabbas
Copy link
Contributor Author

biabbas commented Oct 16, 2024

Do you have links to headers / docs to check against?

Also FYI the commit summary only says "VxWorks"

I am using original sources to check these changes against. Unfortunately, I can't share them.

@tgross35
Copy link
Contributor

Alright, they match linux so I guess that is straightforward enough. It would be good if we could find somebody who can crosscheck these in the future if sources aren't available.

Thanks for updating the commit message.

@tgross35 tgross35 added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@tgross35 tgross35 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into rust-lang:main with commit c5e165f Oct 16, 2024
40 checks passed
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 16, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 16, 2024
@tgross35 tgross35 mentioned this pull request Oct 16, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants