Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing musl utmpx.h constants #3908

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

andrewliebenow
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@andrewliebenow
Copy link
Contributor Author

See https://git.musl-libc.org/cgit/musl/tree/include/utmpx.h?h=v1.1.24.

I'm not sure if adding these constants would be considered a breaking change (https://doc.rust-lang.org/cargo/reference/semver.html#item-new).

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 1, 2024
@andrewliebenow andrewliebenow force-pushed the add-missing-musl-constants branch from 515e8df to 6cd88a4 Compare October 1, 2024 07:22
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added this pull request to the merge queue Oct 1, 2024
Merged via the queue into rust-lang:main with commit 2d221d7 Oct 1, 2024
41 checks passed
@tgross35 tgross35 mentioned this pull request Oct 15, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
(backport <rust-lang#3908>)
(cherry picked from commit 6cd88a4)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
(backport <rust-lang#3908>)
(cherry picked from commit 6cd88a4)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants