-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct types of mode bit constants on Fuchsia #3654
Correct types of mode bit constants on Fuchsia #3654
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Thanks for taking a look at this! I think we should accept this, despite its nominal breaking change status, as this in-principle is the same change as #503 which was also breaking and also accepted-already. Code that currently builds and works on Fuchsia has to type-cast around this somehow anyways. |
Fuchsia's definitions of these constants were split from the unix impls before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly typed as c_int instead of mode_t. This applies the same fix to Fuchsia's constant definitions to bring them in line with the rest of libc.
Co-authored-by: Jubilee <[email protected]>
571f810
to
0338155
Compare
[0.2] Backport #3654 "Correct types of mode bit constants on Fuchsia"
Fuchsia's definitions of these constants were split from the unix impls before #503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly typed as c_int instead of mode_t. This applies the same fix to Fuchsia's constant definitions to bring them in line with the rest of libc.
This is a breaking change since
c_int
isi32
on Fuchsia andmode_t
isu32
, but it's a good breaking change.