attempt to fix #3641 #3647
Merged
attempt to fix #3641 #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
|
Libc tests do run with these fix. Thank you @devnexen. An explanation of this fix would be helpful for my understanding. Please provide an explanation. |
|
Well, those tests were avoided only with musl now we avoid testing those symbols on glibc too. Those discards can be eventually removed once systems are updated at large. |
|
Oh. Okay. Thanks you. |
biabbas
approved these changes
Apr 5, 2024
JohnTitor
force-pushed
the
fix_linux_relr_tests
branch
from
752bb2c to
2e94ad3
Compare
JohnTitor
approved these changes
Apr 17, 2024
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
(backport <rust-lang#3647>) (cherry picked from commit 2e94ad3)
tgross35
added
the
stable-nominated
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.