Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial support for csky-unknown-linux-gnuabiv2 #3301

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

Dirreke
Copy link
Contributor

@Dirreke Dirreke commented Jul 13, 2023

Add libc-files to allow rust to be used on the csky/linux platform with a PR rust-lang/rust#113658 for rust

Signed-off-by: @Dirreke [email protected]

@rustbot
Copy link
Collaborator

rustbot commented Jul 13, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@Dirreke
Copy link
Contributor Author

Dirreke commented Jul 19, 2023

@rustbot review

@Dirreke
Copy link
Contributor Author

Dirreke commented Jul 25, 2023

I know the code to support Linux/csky isn't yet in rust itself; rust-lang/rust#113658 is in process. However, I need this crate merge first, and then rust-lang/rust#113658 ensues because rust depends on libc by using libc::c_charlibc::c_int ...
Thanks!

@Dirreke
Copy link
Contributor Author

Dirreke commented Aug 14, 2023

@JohnTitor May I ask if you have time to review this PR? Thanks

@JohnTitor
Copy link
Member

Could you rebase and squash commits into one?

@Dirreke Dirreke force-pushed the csky-unknown-linux-gnuabiv2 branch from a5a426d to 3d77fc6 Compare August 15, 2023 17:54
@Dirreke
Copy link
Contributor Author

Dirreke commented Aug 15, 2023

Done! Thanks

@Dirreke
Copy link
Contributor Author

Dirreke commented Aug 17, 2023

@JohnTitor Could you merge it? Thanks!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 17, 2023

📌 Commit 3d77fc6 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 17, 2023

⌛ Testing commit 3d77fc6 with merge 92a5d3e...

@bors
Copy link
Contributor

bors commented Aug 17, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 92a5d3e to main...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants