-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: move DCCP_ constants from linux/gnu to linux #3136
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
closes #3132 these constants come from linux headers, so they should be exposed for "linux", not just glibc. this change exposes them for linux/musl and linux/uclibc. of note, android contains these same constants, but moving it to linux-like would also expose them on emscripten, which does not have it.
not sure if the failing freebsd-14 ci is related to any of this |
@JohnTitor Could you rerun the CI? I don't think there is anything related to freebsd in this PR. |
Re-running doesn't help it here as the failure is valid, it has been fixed on master already so we just need |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
closes #3132
these constants come from linux headers, so they should be exposed for "linux", not just glibc.
this change exposes them for linux/musl and linux/uclibc.
of note, android contains these same constants, but moving it to linux-like would also expose them on emscripten, which does not have it.
(not sure if things are placed in the correct place, but this looks like an okayish start)