Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: move DCCP_ constants from linux/gnu to linux #3136

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

nekopsykose
Copy link
Contributor

closes #3132

these constants come from linux headers, so they should be exposed for "linux", not just glibc.

this change exposes them for linux/musl and linux/uclibc.

of note, android contains these same constants, but moving it to linux-like would also expose them on emscripten, which does not have it.

(not sure if things are placed in the correct place, but this looks like an okayish start)

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

closes #3132

these constants come from linux headers, so they should be exposed for
"linux", not just glibc.

this change exposes them for linux/musl and linux/uclibc.

of note, android contains these same constants, but moving it to
linux-like would also expose them on emscripten, which does not have it.
@nekopsykose
Copy link
Contributor Author

not sure if the failing freebsd-14 ci is related to any of this

@zonyitoo
Copy link
Contributor

@JohnTitor Could you rerun the CI? I don't think there is anything related to freebsd in this PR.

@JohnTitor
Copy link
Member

Re-running doesn't help it here as the failure is valid, it has been fixed on master already so we just need
@bors r+

@bors
Copy link
Contributor

bors commented Mar 12, 2023

📌 Commit b5c207a has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 12, 2023

⌛ Testing commit b5c207a with merge 71ec1cf...

@bors
Copy link
Contributor

bors commented Mar 12, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 71ec1cf to master...

@bors bors merged commit 71ec1cf into rust-lang:master Mar 12, 2023
@bors bors mentioned this pull request Mar 12, 2023
mokeyish added a commit to mokeyish/smartdns-rs that referenced this pull request Apr 9, 2023
mokeyish added a commit to mokeyish/smartdns-rs that referenced this pull request Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dccp exports are tied to glibc on linux
5 participants