Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glibc extensions for posix_spawn*. #3119

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

kosayoda
Copy link
Contributor

This PR adds support for posix spawn extensions implemented by glibc: https://elixir.bootlin.com/glibc/glibc-2.37.9000/source/posix/spawn.h#L201.

@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@kosayoda kosayoda marked this pull request as ready for review February 14, 2023 19:55
@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 19, 2023

📌 Commit 2c46c2a has been approved by JohnTitor

It is now in the queue for this repository.

bors added a commit that referenced this pull request Feb 19, 2023
Add glibc extensions for posix_spawn*.

This PR adds support for posix spawn extensions implemented by glibc: https://elixir.bootlin.com/glibc/glibc-2.37.9000/source/posix/spawn.h#L201.
@bors
Copy link
Contributor

bors commented Feb 19, 2023

⌛ Testing commit 2c46c2a with merge e717704...

@bors
Copy link
Contributor

bors commented Feb 19, 2023

💔 Test failed - checks-actions

@kosayoda
Copy link
Contributor Author

As far as I can tell, the sparc64-unknown-linux-gnu test is failing because it's using an older version of glibc?

@JohnTitor
Copy link
Member

As far as I can tell, the sparc64-unknown-linux-gnu test is failing because it's using an older version of glibc?

Yes:

# FIXME: Update to 22.04 once Debian image of sparc64 has a newer glibc.
FROM ubuntu:20.04

You could skip tests for that arch by tweaking libc-test's build.rs.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 22, 2023

📌 Commit fb7d1c5 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 22, 2023

⌛ Testing commit fb7d1c5 with merge 5e98ea3...

@bors
Copy link
Contributor

bors commented Feb 22, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 5e98ea3 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Feb 22, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 5e98ea3 to master...

@bors
Copy link
Contributor

bors commented Feb 22, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit 5e98ea3 into rust-lang:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants