Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user_regs for linux on arm #3072

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Jan 18, 2023

This struct is used for PTRACE_GETREGS & PTRACE_SETREGS. We mirror the name used in glibc. This struct is called pt_regs in the kernel. Instead of a uregs array, we use separate named fields.

  • Edit corresponding file(s) under libc-test/semver when you add/remove item(s)

AFAICT there's no file for linux on arm (not aarch64). Am I missing something here?

@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

If there's not, you can just ignore it :) Since we have a lot of supported env, covering everything is hard and ongoing.
@bors r+

@bors
Copy link
Contributor

bors commented Jan 22, 2023

📌 Commit 2a24356 has been approved by JohnTitor

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jan 22, 2023
add `user_regs` for linux on arm

This struct is used for `PTRACE_GETREGS` & `PTRACE_SETREGS`. We mirror the name used in `glibc`. This struct is called `pt_regs` in the kernel. Instead of a `uregs` array, we use separate named fields.

> - \[ ] Edit corresponding file(s) under `libc-test/semver` when you add/remove item(s)

AFAICT there's no file for linux on arm (not aarch64). Am I missing something here?
@bors
Copy link
Contributor

bors commented Jan 22, 2023

⌛ Testing commit 2a24356 with merge e4ba03f...

@bors
Copy link
Contributor

bors commented Jan 22, 2023

💔 Test failed - checks-actions

This struct is used for `PTRACE_GETREGS` & `PTRACE_SETREGS`. We mirror
the name used in `glibc`. This struct is called `pt_regs` in the kernel.
glibc uses a single array `uregs` instead of individual fields. The
`asm/ptrace.h` header defined by the linux kernel defines macros to
access the individual registers. Instead of `uregs` we just define the
registers as individual fields.
@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 28, 2023

📌 Commit d36bf06 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 28, 2023

⌛ Testing commit d36bf06 with merge 62897a7...

@bors
Copy link
Contributor

bors commented Jan 28, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 62897a7 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Jan 28, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 62897a7 to master...

@bors
Copy link
Contributor

bors commented Jan 28, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit 62897a7 into rust-lang:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants