Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing string-to-number functions from ISO C #3036

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

LegionMammal978
Copy link
Contributor

@LegionMammal978 LegionMammal978 commented Dec 13, 2022

These should be the observable API changes:

  • ISO C90 function atol() is added to all fuchsia, unix, vxworks, wasi, and windows targets.
  • ISO C90 function atof() is added to android, redox, and vxworks.
  • ISO C99 functions atoll(), strtoll(), and strtoull() are added to all fuchsia, unix, vxworks, wasi, and windows targets.

Also, I wasn't exactly sure where to insert the new functions, so I just tried to place them near related functions.

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2022

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@JohnTitor
Copy link
Member

Do you really want to use all of the items? The huge addition makes review harder and may cause unneeded breaking change (if upstream changes ABI, it would introduce a breaking change here. It'd be troublesome when there's no real user but we have to think about the effect of that breaking change).
Also, changing the clock_t type is a breaking change and this PR cannot be merged until we (maintainers) figure out how to set the release policy and ship breaking changes, so I'd recommend dropping the changes that you don't need and separating diff into some PRs.

@LegionMammal978 LegionMammal978 changed the title Add missing functions from ISO C90 and C99, fix definition of clock_t Add missing string-to-number functions from ISO C Dec 14, 2022
@LegionMammal978 LegionMammal978 deleted the iso-c-funcs branch December 14, 2022 15:11
@LegionMammal978 LegionMammal978 restored the iso-c-funcs branch December 14, 2022 15:12
@LegionMammal978
Copy link
Contributor Author

Alright, I've scaled this PR back to just the string-to-number functions, since those were what I was originally missing.

@JohnTitor
Copy link
Member

Great, thanks! @bors r+

@bors
Copy link
Contributor

bors commented Dec 20, 2022

📌 Commit 6a58758 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 20, 2022

⌛ Testing commit 6a58758 with merge 07636f6...

@bors
Copy link
Contributor

bors commented Dec 20, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 07636f6 to master...

@bors bors merged commit 07636f6 into rust-lang:master Dec 20, 2022
flba-eb added a commit to flba-eb/libc that referenced this pull request Feb 21, 2023
This adapts to the changes done with PR rust-lang#3036
bors added a commit that referenced this pull request Mar 1, 2023
Remove duplicated atof function declaration

This adapts to the changes done with PR #3036, removing a function declaration which would exist twice otherwise.

cc: `@gh-tr,` `@samkearney`
tatref pushed a commit to tatref/libc that referenced this pull request Mar 20, 2023
This adapts to the changes done with PR rust-lang#3036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants