-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing string-to-number functions from ISO C #3036
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. |
a1b0e6c
to
8dce85d
Compare
Do you really want to use all of the items? The huge addition makes review harder and may cause unneeded breaking change (if upstream changes ABI, it would introduce a breaking change here. It'd be troublesome when there's no real user but we have to think about the effect of that breaking change). |
8dce85d
to
6a58758
Compare
Alright, I've scaled this PR back to just the string-to-number functions, since those were what I was originally missing. |
Great, thanks! @bors r+ |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
This adapts to the changes done with PR rust-lang#3036
Remove duplicated atof function declaration This adapts to the changes done with PR #3036, removing a function declaration which would exist twice otherwise. cc: `@gh-tr,` `@samkearney`
This adapts to the changes done with PR rust-lang#3036
These should be the observable API changes:
atol()
is added to allfuchsia
,unix
,vxworks
,wasi
, andwindows
targets.atof()
is added toandroid
,redox
, andvxworks
.atoll()
,strtoll()
, andstrtoull()
are added to allfuchsia
,unix
,vxworks
,wasi
, andwindows
targets.Also, I wasn't exactly sure where to insert the new functions, so I just tried to place them near related functions.