Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in CMSG_NXTHDR for android. #1976

Closed
wants to merge 1 commit into from
Closed

Fix bug in CMSG_NXTHDR for android. #1976

wants to merge 1 commit into from

Conversation

LinkTed
Copy link
Contributor

@LinkTed LinkTed commented Nov 15, 2020

CMSG_NXTHDR should return NULL if it is the last control message in the chain.

…L if it is the last control message in the chain.
@rust-highfive
Copy link

r? @JohnTitor

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 23, 2020

📌 Commit 724d1a3 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Nov 23, 2020

⌛ Testing commit 724d1a3 with merge 9b6e9af...

bors added a commit that referenced this pull request Nov 23, 2020
Fix bug in `CMSG_NXTHDR` for android.

`CMSG_NXTHDR` should return NULL if it is the last control message in the chain.
@bors
Copy link
Contributor

bors commented Nov 23, 2020

💔 Test failed - checks-actions

@LinkTed
Copy link
Contributor Author

LinkTed commented Nov 23, 2020

It seems that the android implementation (bionic) is wrong. Should I close the PR?

@JohnTitor
Copy link
Member

Hm, if it's wrong and/or we don't need a fix for rust-lang/rust#69864, then yes.

@LinkTed LinkTed closed this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants