Make HashSet::insert return OccupiedEntry #495
Conversation
|
☔ The latest upstream changes (presumably #502) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Sorry for the late review, can you rebase to fix conflicts? |
Signed-off-by: Alex Saveau <[email protected]>
|
Sure, done. |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Reading this comment: And the changes (i.e. the signature of the |
| @@ -1003,7 +1003,7 @@ where | |||
| /// match singles.entry(ch) { | |||
| /// Vacant(single_entry) => { | |||
| /// // We found a new character for the first time. | |||
| /// single_entry.insert() | |||
| /// single_entry.insert(); | |||
There was a problem hiding this comment.
This exemplifies how it was a breaking change to return something other than ().
|
I've yanked the release. |
|
Will there be a replacement release for the stdlib? |
|
Yes, I'll prepare a new release next week. I've been busy at Rust Nation this week. |
|
Oh fun! Sounds good. |
Release 0.14.5 This temporarily reverts (#495) since that is a breaking change that will be included in v0.15.0.
See rust-lang/rust#120077 (comment)