Build crates with minimal versions in CI #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajorBreakfast
commented
Aug 10, 2018
| - cargo build --manifest-path futures-executor/Cargo.toml --all-features | ||
| - cargo build --manifest-path futures-io/Cargo.toml --all-features | ||
| - cargo build --manifest-path futures-sink/Cargo.toml --all-features | ||
| - cargo build --manifest-path futures-util/Cargo.toml --all-features |
There was a problem hiding this comment.
Could we use cargo build --all-features or cargo build -p futures-... --all-features instead?
cargo build --no-default-features seems not to exist at least
There was a problem hiding this comment.
cargo build --all-features might also not work. It exists but I'm not sure whether it does what we want
There was a problem hiding this comment.
Nope, features and workspaces are pretty much broken at the moment. There was an attempt at fixing them a while ago, but I’m not sure if that’s still available even as an unstable flag. I’ll try and find the link to the issue in a sec.
There was a problem hiding this comment.
I tested -p instead of --manifest-path and it doesn't work
MajorBreakfast
force-pushed
the
ci-min-versions
branch
from
cab3b41 to
1949748
Compare
Nemo157
approved these changes
Aug 10, 2018
MajorBreakfast
force-pushed
the
ci-min-versions
branch
from
6ee239e to
a105d7c
Compare
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #1189
The CI should break if we're relying on features not available in the minimal versions we specify.
cc @cramertj