Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add future::pinned combinator #1023

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions futures-util/src/future/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ use futures_core::{Future, Stream};
// Primitive futures
mod empty;
mod lazy;
mod pinned;
mod poll_fn;
pub use self::empty::{empty, Empty};
pub use self::lazy::{lazy, Lazy};
pub use self::pinned::{pinned, PinnedFut};
pub use self::poll_fn::{poll_fn, PollFn};

// combinators
Expand Down
116 changes: 116 additions & 0 deletions futures-util/src/future/pinned.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
//! Definition of the `PinnedFut` adapter combinator

// TODO: import `Pinned` and use it to make `Borrowed` immovable.
use core::mem::PinMut;

use futures_core::{Future, Poll};
use futures_core::task;

pub trait PinnedFnLt<'a, Data: 'a, Output> {
type Future: Future<Output = Output> + 'a;
fn apply(self, data: PinMut<'a, Data>) -> Self::Future;
}

pub trait PinnedFn<Data, Output>: for<'a> PinnedFnLt<'a, Data, Output> + 'static {}
impl<Data, Output, T> PinnedFn<Data, Output> for T
where T: for<'a> PinnedFnLt<'a, Data, Output> + 'static {}

impl<'a, Data, Output, Fut, T> PinnedFnLt<'a, Data, Output> for T
where
Data: 'a,
T: FnOnce(PinMut<'a, Data>) -> Fut,
Fut: Future<Output = Output> + 'a,
{
type Future = Fut;
fn apply(self, data: PinMut<'a, Data>) -> Self::Future {
(self)(data)
}
}

/// A future which borrows a value for an asynchronous lifetime.
///
/// Created by the `borrowed` function.
#[must_use = "futures do nothing unless polled"]
#[allow(missing_debug_implementations)]
pub struct PinnedFut<Data: 'static, Output, F: PinnedFn<Data, Output>> {
fn_or_fut: FnOrFut<Data, Output, F>,
// TODO:
// marker: Pinned,
// Data, which may be borrowed by `fn_or_fut`, must be dropped last
data: Data,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should use ManuallyDrop so as to not rely on drop order?

(AFAIK drop order is actually "first field is dropped last", so this may even be wrong right now.)

}

enum FnOrFut<Data: 'static, Output, F: PinnedFn<Data, Output>> {
F(F),
Fut(<F as PinnedFnLt<'static, Data, Output>>::Future),
None,
}

impl<Data: 'static, Output, F: PinnedFn<Data, Output>> FnOrFut<Data, Output, F> {
fn is_fn(&self) -> bool {
if let FnOrFut::F(_) = self {
true
} else {
false
}
}
}

/// Creates a new future which pins some data and borrows it for an
/// asynchronous lifetime.
pub fn pinned<Data, Output, F>(data: Data, f: F) -> PinnedFut<Data, Output, F>
where F: PinnedFn<Data, Output>,
Data: 'static,
{
PinnedFut {
fn_or_fut: FnOrFut::F(f),
data,
}
}

unsafe fn transmute_lt<'input, 'output, T>(x: &'input mut T) -> &'output mut T {
::std::mem::transmute(x)
}

impl<Data, Output, F> Future for PinnedFut<Data, Output, F>
where F: PinnedFn<Data, Output>,
Data: 'static,
{
type Output = <<F as PinnedFnLt<'static, Data, Output>>::Future as Future>::Output;

fn poll(self: PinMut<Self>, cx: &mut task::Context) -> Poll<Self::Output> {
unsafe {
let this = PinMut::get_mut(self);
if this.fn_or_fut.is_fn() {
if let FnOrFut::F(f) = ::std::mem::replace(&mut this.fn_or_fut, FnOrFut::None) {
let fut = f.apply(PinMut::new_unchecked(transmute_lt(&mut this.data)));
this.fn_or_fut = FnOrFut::Fut(fut);
} else {
unreachable!()
}
}

let res = if let FnOrFut::Fut(fut) = &mut this.fn_or_fut {
PinMut::new_unchecked(fut).poll(cx)
} else {
panic!("polled PinnedFut after completion")
};

if let Poll::Ready(_) = &res {
this.fn_or_fut = FnOrFut::None;
}

res
}
}
}

#[allow(unused)]
fn does_compile() -> impl Future<Output = u8> {
pinned(5, |x: PinMut<_>| { // This type annotation is *required* to compile
::future::lazy(move |_cx| {
// we can use (copy from) the asynchronously borrowed data here
*x
})
})
}