-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract rustc stable hasher into it's own crate #755
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:
Concerns can be lifted with:
See documentation at https://forge.rust-lang.org cc @rust-lang/compiler @rust-lang/compiler-contributors |
@rustbot second |
@rustbot label -final-comment-period +major-change-accepted |
…erister Use rustc-stable-hash in the compiler Following rust-lang/compiler-team#755 and the release of the crate on crates.io, let's now use it in the compiler and remove the old implementation. cc `@michaelwoerister` r? ghost
Proposal
Extract the
StableHasher
(struct),StableHasherResult
(trait) andSipHasher128
(struct) fromrustc_data_structures
into their own (new) craterustc-stable-hash
, similar torustc-hash
, so they can be used by other projects.In particular, this would be useful for Cargo, which needs a cross-platform independent stable hasher for the trim-paths feature, rust-lang/cargo#13171 (comment).
The plan is to create a separate repo
rustc-stable-hash
(already done), create the infra1, import those parts1, publish the crate, use the new crate inrustc_data_structures
.Mentors or Reviewers
My-self, @Urgau.
Process
The main points of the Major Change Process are as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
Footnotes
https://github.com/rust-lang/rustc-stable-hash/pull/1 ↩ ↩2
The text was updated successfully, but these errors were encountered: