Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate __builtin_clz symbols on MSVC Windows #167

Closed
alexcrichton opened this issue Jun 24, 2017 · 2 comments · Fixed by #574
Closed

Duplicate __builtin_clz symbols on MSVC Windows #167

alexcrichton opened this issue Jun 24, 2017 · 2 comments · Fixed by #574

Comments

@alexcrichton
Copy link
Member

This is due to the fact that their definition is not marked static. Filing an issue to track this, gonna add a FIXME for now.
@alexcrichton
Copy link
Member Author

I opened an upstream diff for this.

@AaronKutch
Copy link
Contributor

What's the status on this?

@trevyn trevyn mentioned this issue Oct 17, 2023
Merged
@trevyn trevyn mentioned this issue Jan 8, 2024
Merged
compnerd pushed a commit to llvm/llvm-project that referenced this issue Jan 19, 2024
@trevyn
[builtins] Mark int_lib.h builtins as static (#69305)
d1a2f11 
Mark the following symbols as `static` to prevent duplicate definitions:

`__builtin_ctz`
`__builtin_clz`
`__builtin_clzll`
`__builtin_sadd_overflow`

>Without these then all of these functions show up in all object files
which include int_lib.h on Windows. This'll help prevent duplicate
symbols by ensuring they're not exported.

See:

rust-lang/compiler-builtins#167
https://reviews.llvm.org/D34599
@trevyn trevyn mentioned this issue Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate symbol workaround trevyn/compiler-builtins
2 participants
@alexcrichton @AaronKutch