On darwin, explicitly set CMAKE_OSX_ARCHITECTURES to avoid creating fat libraries #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
approved these changes
Oct 26, 2022
| @@ -628,6 +628,16 @@ impl Config { | |||
| cmd.arg("-DCMAKE_OSX_SYSROOT=/"); | |||
| cmd.arg("-DCMAKE_OSX_DEPLOYMENT_TARGET="); | |||
| } | |||
| } else if target.contains("darwin") { | |||
| if !self.defined("CMAKE_OSX_ARCHITECTURES") { | |||
| if target.contains("x86_64") { | |||
There was a problem hiding this comment.
This will be broken for x86_64h-apple-darwin if Rust ever adds it in the future (clang has this target, for example). This is a note to self as much as anything, and there's no need to handle hypothetical targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without explicitly CMAKE_OSX_ARCHITECTURES, when crosscompiling for x86_64 on aarch64 the libraries created are wonky and cannot be linked against.