Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated Error::description method #7698

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Remove use of deprecated Error::description method #7698

merged 1 commit into from
Dec 12, 2019

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Dec 12, 2019

We are getting ready to deprecate std::error::Error::description: rust-lang/rust#66919. This PR replaces one place that should be using Display instead.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2019
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will merge once CI is fixed by #7699.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 12, 2019

📌 Commit e08a3ce has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2019
@bors
Copy link
Contributor

bors commented Dec 12, 2019

⌛ Testing commit e08a3ce with merge 19a0de2...

bors added a commit that referenced this pull request Dec 12, 2019
Remove use of deprecated Error::description method

We are getting ready to deprecate std::error::Error::description: rust-lang/rust#66919. This PR replaces one place that should be using Display instead.
@bors
Copy link
Contributor

bors commented Dec 12, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 19a0de2 to master...

@bors bors merged commit e08a3ce into rust-lang:master Dec 12, 2019
@dtolnay dtolnay deleted the description branch December 14, 2019 22:08
@ehuss ehuss added this to the 1.42.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants