Add and move tests for jobs of cargo build
#7695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test when argument is negative is added. In addition, `default_cargo_config_jobs` and `good_cargo_config_jobs` is moved from `testsuite/bad_config.rs` to `testsuite/build.rs` because these tests are not for `bad config`.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ehuss
reviewed
Dec 11, 2019
src/cargo/core/manifest.rs
Outdated
| @@ -222,7 +222,7 @@ impl TargetKind { | |||
| } | |||
| } | |||
|
|
|||
| /// Information about a binary, a library, an example, etc. that is part of the | |||
| /// Information about a binary, a library, an example, etc. That is part of the | |||
There was a problem hiding this comment.
I don't think this is really a typo. Deconstructing:
Information about a thing that is part of the package.
The second part isn't a separate sentence.
There was a problem hiding this comment.
Indeed, this is not typo as you pointed out. I remove this commit from PR.
giraffate
force-pushed
the
add_and_update_tests_for_jobs_of_cargo_build
branch
from
1ac3ad3 to
4956d3e
Compare
giraffate
changed the title
cargo build and fix typocargo build
|
The fix for typo was my mistake, so I removed that commit and fixed the title and summary. Could you review this again? |
|
@bors: r=ehuss |
|
📌 Commit 4956d3e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 12, 2019
…o_build, r=ehuss Add and move tests for jobs of `cargo build` A test when argument is negative is added. In addition, `default_cargo_config_jobs` and `good_cargo_config_jobs` is moved from `testsuite/bad_config.rs` to `testsuite/build.rs` because these tests are not for `bad config`.
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test when argument is negative is added. In addition,
default_cargo_config_jobsandgood_cargo_config_jobsis moved fromtestsuite/bad_config.rstotestsuite/build.rsbecause these tests are not forbad config.