-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify manifest format docs for [badges] section #7694
Clarify manifest format docs for [badges] section #7694
Conversation
Previously the `[badges]` section documentation was mixed in with the `[package]` section. This extracts it out under its own heading. This also pulls the `license` and `license-file` field documentation out of the package metadata code block. It sets the example license to “MIT OR Apache-2.0” since that is the typical licensing scheme for many crates. This includes minor rewrites for clarity and to match the register of the rest of the document. This resolves issue #7691.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Looks good to me, @ehuss Thoughts? |
Looks great, thank you! |
📌 Commit 80e37c3 has been approved by |
⌛ Testing commit 80e37c3 with merge 6f9b77a11b0fec288128af5a7df04da7d841ca45... |
💔 Test failed - checks-azure |
@bors retry |
… r=ehuss Clarify manifest format docs for [badges] section Previously the `[badges]` section documentation was mixed in with the `[package]` section. This extracts it out under its own heading. This also pulls the `license` and `license-file` field documentation out of the package metadata code block. It sets the example license to “MIT OR Apache-2.0” since that is the typical licensing scheme for many crates. This includes minor rewrites for clarity and to match the register of the rest of the document. This resolves issue #7691.
☀️ Test successful - checks-azure |
Previously the
[badges]
section documentation was mixed in with the[package]
section. This extracts it out under its own heading.This also pulls the
license
andlicense-file
field documentation out of the package metadata code block. It sets the example license to “MIT OR Apache-2.0” since that is the typical licensing scheme for many crates.This includes minor rewrites for clarity and to match the register of the rest of the document.
This resolves issue #7691.