Support having a generic writer instead of a termcolor StandardStream #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cargo/core/shell.rs
Outdated
| write!(err, " {}\n", message)?; | ||
| Ok(()) | ||
| } | ||
| ShellOut::Write(_) => unimplemented!(), |
There was a problem hiding this comment.
This'll cause panics when used from the rls, right?
src/cargo/core/shell.rs
Outdated
| fn as_write(&mut self) -> &mut Write { | ||
| match *self { | ||
| ShellOut::Stream(ref mut err, _) => err, | ||
| ShellOut::Write(_) => unimplemented!(), |
This is requied by the RLS (and presumably any other client who wants to use Cargo as a lib and redirect output)
|
Whoops, sorry about that. Now with actual implementations. |
|
@bors: r+ |
|
📌 Commit 6f45cb6 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 17, 2017
Support having a generic writer instead of a termcolor StandardStream This is requied by the RLS (and presumably any other client who wants to use Cargo as a lib and redirect output) r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is requied by the RLS (and presumably any other client who wants to use Cargo as a lib and redirect output)
r? @alexcrichton