Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #1306
This cannot be merged now, since it don't hide password because I cannot find a cross-platform way to do it using std library or
crates.io
. (rpassword don't build on Windows because of the dependency to termios)https://github.com/jeaye/ncurses-rs seems close to work on Windows, maybe we could make a new crate that handle password input through ncurses-rs. BTW, ncurses-rs isn't on crates.io (yet).
And after all, maybe the whole idea about prompting on
cargo update
is wrong.So I make this PR mainly for help and revise.