Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for password if needed #1308

Closed
wants to merge 2 commits into from

Conversation

bombless
Copy link

Try to fix #1306
This cannot be merged now, since it don't hide password because I cannot find a cross-platform way to do it using std library or crates.io. (rpassword don't build on Windows because of the dependency to termios)

https://github.com/jeaye/ncurses-rs seems close to work on Windows, maybe we could make a new crate that handle password input through ncurses-rs. BTW, ncurses-rs isn't on crates.io (yet).

And after all, maybe the whole idea about prompting on cargo update is wrong.

So I make this PR mainly for help and revise.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@bombless bombless changed the title Prompt for keyword if needed Prompt for password if needed Feb 14, 2015
@alexcrichton
Copy link
Member

Unfortunately hiding the typing of the password was why I did not implement this in the first place, and I think that it's a hard requirement for a feature such as this. In light of this I'm going to close this for now, but thanks for the proof-of-concept implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will Cargo prompt for username & password when fetching Git repo?
3 participants